RE: [PATCH 09/12] net: mana: Move header files to a common location

Long Li
2022-05-17T19:49:24Z

> Subject: Re: [PATCH 09/12] net: mana: Move header files to a common location
>
> On Tue, May 17, 2022 at 02:04:33AM -0700, longli@linuxonhyperv.com wrote:
> > From: Long Li <longli@microsoft.com>
> >
> > In preparation to add MANA RDMA driver, move all the required header
> > files to a common location for use by both Ethernet and RDMA drivers.
> >
> > Signed-off-by: Long Li <longli@microsoft.com>
> > ---
> > MAINTAINERS | 1 +
> > drivers/net/ethernet/microsoft/mana/gdma_main.c | 2 +-
> > drivers/net/ethernet/microsoft/mana/hw_channel.c | 4 ++--
> > drivers/net/ethernet/microsoft/mana/mana_bpf.c | 2 +-
> > drivers/net/ethernet/microsoft/mana/mana_en.c | 2 +-
> > drivers/net/ethernet/microsoft/mana/mana_ethtool.c | 2 +-
> > drivers/net/ethernet/microsoft/mana/shm_channel.c | 2 +-
> > {drivers/net/ethernet/microsoft => include/linux}/mana/gdma.h | 0
> > .../ethernet/microsoft => include/linux}/mana/hw_channel.h | 0
> > {drivers/net/ethernet/microsoft => include/linux}/mana/mana.h | 0
> > .../ethernet/microsoft => include/linux}/mana/shm_channel.h | 0
> > 11 files changed, 8 insertions(+), 7 deletions(-) rename
> > {drivers/net/ethernet/microsoft => include/linux}/mana/gdma.h (100%)
> > rename {drivers/net/ethernet/microsoft =>
> > include/linux}/mana/hw_channel.h (100%) rename
> > {drivers/net/ethernet/microsoft => include/linux}/mana/mana.h (100%)
> > rename {drivers/net/ethernet/microsoft =>
> > include/linux}/mana/shm_channel.h (100%)
>
> I know mlx5 did it like this, but I wonder if include/net is more appropriate?
>
> Or maybe include/aux/?

I can move the header files to include/net/mana, if that sounds okay and no objection to doing that.

Long

>
> Jason