From: Jason Gunthorpe <jgg@nvidia.com>
To: cgel.zte@gmail.com
Cc: mkalderon@marvell.com, aelior@marvell.com, leon@kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] qedr: Remove unnecessary synchronize_irq() before free_irq()
Date: Tue, 17 May 2022 08:54:29 -0300 [thread overview]
Message-ID: <20220517115429.GA1901088@nvidia.com> (raw)
In-Reply-To: <20220513081647.1631141-1-chi.minghao@zte.com.cn>
On Fri, May 13, 2022 at 08:16:47AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered, on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way), before any state associated with the IRQ is freed.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
> ---
> drivers/infiniband/hw/qedr/main.c | 1 -
> 1 file changed, 1 deletion(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2022-05-17 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 8:16 [PATCH] qedr: Remove unnecessary synchronize_irq() before free_irq() cgel.zte
2022-05-15 10:12 ` [EXT] " Michal Kalderon
2022-05-17 11:54 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517115429.GA1901088@nvidia.com \
--to=jgg@nvidia.com \
--cc=aelior@marvell.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mkalderon@marvell.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox