Re: [PATCH v3 23/23] MAINTAINERS: Add maintainers for DWC AHCI SATA driver

Serge Semin
2022-05-12T16:47:45Z

On Thu, May 12, 2022 at 09:16:19AM +0200, Hannes Reinecke wrote:
> On 5/12/22 01:18, Serge Semin wrote:
> > Add myself as a maintainer of the new DWC AHCI SATA driver and
> > its DT-bindings schema.
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> >
> > ---
> >
> > Changelog v2:
> > - Use dlemoal/libata.git git tree for the LIBATA SATA AHCI SYNOPSYS
> > DWC driver (@Damien).
> > ---
> > MAINTAINERS | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 40fa1955ca3f..04f470519708 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11135,6 +11135,15 @@ F: drivers/ata/ahci_platform.c
> > F: drivers/ata/libahci_platform.c
> > F: include/linux/ahci_platform.h
> > +LIBATA SATA AHCI SYNOPSYS DWC CONTROLLER DRIVER
> > +M: Serge Semin <fancer.lancer@gmail.com>
> > +L: linux-ide@vger.kernel.org
> > +S: Maintained
> > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git
> > +F: Documentation/devicetree/bindings/ata/baikal,bt1-ahci.yaml
> > +F: Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml
> > +F: drivers/ata/ahci_dwc.c
> > +
> > LIBATA SATA PROMISE TX2/TX4 CONTROLLER DRIVER
> > M: Mikael Pettersson <mikpelinux@gmail.com>
> > L: linux-ide@vger.kernel.org
> Tsk.
>
> One would have thought that you'd be using the same email address for
> sending patches, and not specifying a different one for the maintainers
> file. There is this thing about proof of authenticity and all that ...
>
> I'm not really comfortable with this. Please use the same email address for
> both the Maintainers file and for sending patches.

I am more comfortable with reviewing and emailing from my private
email box rather than from the corporate one. Moreover the corporate
email address tends to get changed much more frequent than the private
one while the person role still preserves. Keeping more stable address
in the MAINTAINERS file gives a benefit of providing better review
service and causes less consequent modifications. So to speak I'd stick
with keeping the email address as is here.

-Sergey

>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke Kernel Storage Architect
> hare@suse.de +49 911 74053 688
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
> HRB 36809 (AG Nürnberg), GF: Felix Imendörffer