From: Max Krummenacher <max.oss.09@gmail.com>
To: max.krummenacher@toradex.com
Cc: Marek Vasut <marex@denx.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Maxime Ripard <mripard@kernel.org>,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Sam Ravnborg <sam@ravnborg.org>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] drm/panel: simple: add bus-format support for panel-dpi
Date: Wed, 18 May 2022 13:55:40 +0200 [thread overview]
Message-ID: <20220518115541.38407-4-max.oss.09@gmail.com> (raw)
In-Reply-To: <20220518115541.38407-1-max.oss.09@gmail.com>
From: Max Krummenacher <max.krummenacher@toradex.com>
Evaluate the device tree bus-format property to set bus_format for
a 'panel-dpi' panel. Additionally infer the bpc value from the
given bus-format.
Valid values for bus-format are found in:
<include/dt-bindings/display/dt-media-bus-format.h>
This completes the addition of panel-dpi to completely specify
a panel-simple panel from the device tree.
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
Changes in v2:
None
drivers/gpu/drm/panel/panel-simple.c | 43 ++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index a34f4198a534..090c60abb014 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -21,6 +21,7 @@
* DEALINGS IN THE SOFTWARE.
*/
+#include <dt-bindings/display/dt-media-bus-format.h>
#include <linux/delay.h>
#include <linux/gpio/consumer.h>
#include <linux/module.h>
@@ -453,6 +454,7 @@ static int panel_dpi_probe(struct device *dev,
struct panel_desc *desc;
unsigned int bus_flags;
struct videomode vm;
+ u32 bus_format;
int ret;
np = dev->of_node;
@@ -477,6 +479,47 @@ static int panel_dpi_probe(struct device *dev,
of_property_read_u32(np, "width-mm", &desc->size.width);
of_property_read_u32(np, "height-mm", &desc->size.height);
+ if (!of_property_read_u32(np, "bus-format", &bus_format)) {
+ /* infer bpc from bus-format */
+ switch (bus_format) {
+ case DT_MEDIA_BUS_FMT_RGB565_1X16:
+ desc->bus_format = MEDIA_BUS_FMT_RGB565_1X16;
+ desc->bpc = 6;
+ break;
+ case DT_MEDIA_BUS_FMT_RGB666_1X18:
+ desc->bus_format = MEDIA_BUS_FMT_RGB666_1X18;
+ desc->bpc = 6;
+ break;
+ case DT_MEDIA_BUS_FMT_RGB666_1X24_CPADHI:
+ desc->bus_format = MEDIA_BUS_FMT_RGB666_1X24_CPADHI;
+ desc->bpc = 6;
+ break;
+ case DT_MEDIA_BUS_FMT_BGR888_1X24:
+ desc->bus_format = MEDIA_BUS_FMT_BGR888_1X24;
+ desc->bpc = 8;
+ break;
+ case DT_MEDIA_BUS_FMT_GBR888_1X24:
+ desc->bus_format = MEDIA_BUS_FMT_GBR888_1X24;
+ desc->bpc = 8;
+ break;
+ case DT_MEDIA_BUS_FMT_RBG888_1X24:
+ desc->bus_format = MEDIA_BUS_FMT_RBG888_1X24;
+ desc->bpc = 8;
+ break;
+ case DT_MEDIA_BUS_FMT_RGB888_1X24:
+ desc->bus_format = MEDIA_BUS_FMT_RGB888_1X24;
+ desc->bpc = 8;
+ break;
+ case DT_MEDIA_BUS_FMT_RGB888_1X32_PADHI:
+ desc->bus_format = MEDIA_BUS_FMT_RGB888_1X32_PADHI;
+ desc->bpc = 8;
+ break;
+ default:
+ dev_err(dev, "%pOF: unknown bus-format property\n", np);
+ return -EINVAL;
+ }
+ }
+
/* Extract bus_flags from display_timing */
bus_flags = 0;
vm.flags = timing->flags;
--
2.20.1
prev parent reply other threads:[~2022-05-18 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 11:55 [PATCH v2 0/3] drm/panel: simple: add bus-format support for panel-dpi Max Krummenacher
2022-05-18 11:55 ` [PATCH v2 1/3] dt-bindings: display: add new bus-format property " Max Krummenacher
2022-06-01 20:16 ` Rob Herring
2022-06-28 17:54 ` Max Krummenacher
2022-05-18 11:55 ` [PATCH v2 2/3] dt-bindings: display: startek,startek-kd050c: allow bus-format property Max Krummenacher
2022-05-18 11:55 ` Max Krummenacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518115541.38407-4-max.oss.09@gmail.com \
--to=max.oss.09@gmail.com \
--cc=airlied@linux.ie \
--cc=cniedermaier@dh-electronics.com \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=francesco.dolcini@toradex.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=max.krummenacher@toradex.com \
--cc=mripard@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox