From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDE4FC433F5 for ; Wed, 18 May 2022 12:35:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237195AbiERMfh (ORCPT ); Wed, 18 May 2022 08:35:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237065AbiERMeP (ORCPT ); Wed, 18 May 2022 08:34:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA488195933; Wed, 18 May 2022 05:30:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 65642B81F40; Wed, 18 May 2022 12:30:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7A7CC385AA; Wed, 18 May 2022 12:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652877000; bh=BUNLhRfompu2Orpy6NY8TgsXhVZK+k4CPtKbD4EVduU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fQgUOXB+mlYIm/O+IiLbdhX0oq2VHMAAU3TkzlAx7tUGJTYEeKfEXPo6AN7FmQdv5 gHaWasEhj+EiyF8EEr+rkwwNCOj1Qfly/8eGVvs5DoXIONCEyYEj/l2n1uc5dS4PzF 4qPEhuwZ8G0sz4+rjfzrf2lJ0VqZFDoNgbd+gxRKNNMzEJFMPU42NcSe3Dp540Q1JY oXDBOczzd1c9Xd/IMtyEWt3qUKlWfsyz120jzS5sVMgJG2RvTt2UV+Hhv8BoNqiH0y Ude8098+UJEhWRftFPWDHl6zOHIHXLBjkMibEySD20z6c85usvYzRFI/Tc0kHR5F9v FcsHZy7/GrM6g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Grant Grundler , Aashay Shringarpure , Yi Chou , Shervin Oloumi , "David S . Miller" , Sasha Levin , irusskikh@marvell.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 5/5] net: atlantic: verify hw_head_ lies within TX buffer ring Date: Wed, 18 May 2022 08:29:45 -0400 Message-Id: <20220518122946.343712-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220518122946.343712-1-sashal@kernel.org> References: <20220518122946.343712-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grant Grundler [ Upstream commit 2120b7f4d128433ad8c5f503a9584deba0684901 ] Bounds check hw_head index provided by NIC to verify it lies within the TX buffer ring. Reported-by: Aashay Shringarpure Reported-by: Yi Chou Reported-by: Shervin Oloumi Signed-off-by: Grant Grundler Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c index c4f914a29c38..bdb0b37c048a 100644 --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c @@ -637,6 +637,13 @@ static int hw_atl_b0_hw_ring_tx_head_update(struct aq_hw_s *self, err = -ENXIO; goto err_exit; } + + /* Validate that the new hw_head_ is reasonable. */ + if (hw_head_ >= ring->size) { + err = -ENXIO; + goto err_exit; + } + ring->hw_head = hw_head_; err = aq_hw_err_from_flags(self); -- 2.35.1