From: Yajun Deng <yajun.deng@linux.dev>
To: pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com
Cc: x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Yajun Deng <yajun.deng@linux.dev>
Subject: [PATCH] KVM: x86: Move kzalloc out of atomic context on PREEMPT_RT
Date: Thu, 19 May 2022 17:02:18 +0800 [thread overview]
Message-ID: <20220519090218.2230653-1-yajun.deng@linux.dev> (raw)
The memory allocator is fully preemptible and therefore cannot
be invoked from truly atomic contexts.
See Documentation/locking/locktypes.rst (line: 470)
Add raw_spin_unlock() before memory allocation and raw_spin_lock()
after it.
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
arch/x86/kernel/kvm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index d0bb2b3fb305..8f8ec9bbd847 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -205,7 +205,9 @@ void kvm_async_pf_task_wake(u32 token)
* async PF was not yet handled.
* Add dummy entry for the token.
*/
- n = kzalloc(sizeof(*n), GFP_ATOMIC);
+ raw_spin_unlock(&b->lock);
+ n = kzalloc(sizeof(*n), GFP_KERNEL);
+ raw_spin_lock(&b->lock);
if (!n) {
/*
* Allocation failed! Busy wait while other cpu
--
2.25.1
next reply other threads:[~2022-05-19 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 9:02 Yajun Deng [this message]
2022-05-19 15:11 ` [PATCH] KVM: x86: Move kzalloc out of atomic context on PREEMPT_RT Sean Christopherson
2022-05-20 13:41 ` Paolo Bonzini
2022-05-20 14:49 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519090218.2230653-1-yajun.deng@linux.dev \
--to=yajun.deng@linux.dev \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox