From: Mel Gorman <mgorman@techsingularity.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Aubrey Li <aubrey.li@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] sched/numa: Adjust imb_numa_nr to a better approximation of memory channels
Date: Thu, 19 May 2022 10:29:13 +0100 [thread overview]
Message-ID: <20220519092913.GU3441@techsingularity.net> (raw)
In-Reply-To: <20220518170625.GT3441@techsingularity.net>
On Wed, May 18, 2022 at 06:06:25PM +0100, Mel Gorman wrote:
> I'm running the tests to recheck exactly how much impact this patch has
> on the peak performance. It takes a few hours so I won't have anything
> until tomorrow.
>
It wasn't my imagination, the last path was worth a few percent
v5.3 Min 95.84 Max 96.55 Range 0.71 Mean 96.16
v5.7 Min 95.44 Max 96.51 Range 1.07 Mean 96.14
v5.8 Min 96.02 Max 197.08 Range 101.06 Mean 154.70
v5.12 Min 104.45 Max 111.03 Range 6.58 Mean 105.94
v5.13 Min 104.38 Max 170.37 Range 65.99 Mean 117.35
v5.13-revert-c6f886546cb8 Min 104.40 Max 110.70 Range 6.30 Mean 105.68
v5.18rc4-baseline Min 110.78 Max 169.84 Range 59.06 Mean 131.22
v5.18rc4-revert-c6f886546cb8 Min 113.98 Max 117.29 Range 3.31 Mean 114.71
v5.18rc4-shiftimb3-v2r2 Min 95.34 Max 165.75 Range 70.41 Mean 120.92
v5.18rc4-consistimb-v2r2 Min 104.02 Max 175.22 Range 71.20 Mean 116.62
v5.18rc4-consistimb-revert-c6f886546cb8 Min 104.02 Max 112.56 Range 8.54 Mean 105.52
v5.18rc4-shiftimb3-v2r2 is patches 1-4
v5.18rc4-consistimb-v2r2 is patches 1-3
The last path is worth around 8% and is what's necessary to bring best
performance back to kernel v5.7 levels. As you can see from the range,
the result is unstable but reverting c6f886546cb8 reduces it by a lot.
Not enough to be at v5.7 levels but enough to indicate that the allowed
NUMA balance changes are not the sole source of the problem.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2022-05-19 9:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 14:30 [PATCH 0/4] Mitigate inconsistent NUMA imbalance behaviour Mel Gorman
2022-05-11 14:30 ` [PATCH 1/4] sched/numa: Initialise numa_migrate_retry Mel Gorman
2022-05-11 14:30 ` [PATCH 2/4] sched/numa: Do not swap tasks between nodes when spare capacity is available Mel Gorman
2022-05-11 14:30 ` [PATCH 3/4] sched/numa: Apply imbalance limitations consistently Mel Gorman
2022-05-18 9:24 ` [sched/numa] bb2dee337b: unixbench.score -11.2% regression kernel test robot
2022-05-18 15:22 ` Mel Gorman
2022-05-19 7:54 ` ying.huang
2022-05-20 6:44 ` [LKP] " Ying Huang
2022-05-18 9:31 ` [PATCH 3/4] sched/numa: Apply imbalance limitations consistently Peter Zijlstra
2022-05-18 10:46 ` Mel Gorman
2022-05-18 13:59 ` Peter Zijlstra
2022-05-18 15:39 ` Mel Gorman
2022-05-11 14:30 ` [PATCH 4/4] sched/numa: Adjust imb_numa_nr to a better approximation of memory channels Mel Gorman
2022-05-18 9:41 ` Peter Zijlstra
2022-05-18 11:15 ` Mel Gorman
2022-05-18 14:05 ` Peter Zijlstra
2022-05-18 17:06 ` Mel Gorman
2022-05-19 9:29 ` Mel Gorman [this message]
2022-05-20 4:58 ` [PATCH 0/4] Mitigate inconsistent NUMA imbalance behaviour K Prateek Nayak
2022-05-20 10:18 ` Mel Gorman
2022-05-20 15:17 ` K Prateek Nayak
-- strict thread matches above, loose matches on Subject: below --
2022-05-20 10:35 [PATCH v2 " Mel Gorman
2022-05-20 10:35 ` [PATCH 4/4] sched/numa: Adjust imb_numa_nr to a better approximation of memory channels Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519092913.GU3441@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=aubrey.li@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox