From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: tytso@mit.edu, Jason@zx2c4.com, hch@lst.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET 0/2] Fix splice from random/urandom
Date: Thu, 19 May 2022 21:48:38 +0200 [thread overview]
Message-ID: <20220519194838.GA6361@lst.de> (raw)
In-Reply-To: <20220519193133.194138-1-axboe@kernel.dk>
On Thu, May 19, 2022 at 01:31:31PM -0600, Jens Axboe wrote:
> Hi,
>
> We recently had a failure on a kernel upgrade because splice no longer
> works on random/urandom. This is due to:
>
> 6e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
>
> which already has more than two handful of Fixes registered to its
> name...
Yes. It was a hard break to get rid of set_fs and it's abuse.
next prev parent reply other threads:[~2022-05-19 19:48 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 19:31 [PATCHSET 0/2] Fix splice from random/urandom Jens Axboe
2022-05-19 19:31 ` [PATCH 1/2] random: convert to using fops->read_iter() Jens Axboe
2022-05-19 23:12 ` Jason A. Donenfeld
2022-05-19 23:20 ` Jason A. Donenfeld
2022-05-19 23:21 ` Jens Axboe
2022-05-19 23:21 ` Jason A. Donenfeld
2022-05-19 23:21 ` Jens Axboe
2022-05-19 19:31 ` [PATCH 2/2] random: wire up fops->splice_read_iter() Jens Axboe
2022-05-19 19:48 ` Christoph Hellwig [this message]
2022-05-19 19:55 ` [PATCHSET 0/2] Fix splice from random/urandom Jens Axboe
2022-05-20 6:02 ` Christoph Hellwig
2022-05-20 12:51 ` Jens Axboe
2022-05-19 20:05 ` Jason A. Donenfeld
2022-05-19 20:49 ` Jens Axboe
2022-05-19 21:02 ` Jens Axboe
2022-05-19 23:15 ` Jason A. Donenfeld
2022-05-19 23:22 ` Jens Axboe
2022-05-19 23:25 ` Jason A. Donenfeld
2022-05-19 23:33 ` Jens Axboe
2022-05-19 23:39 ` Jason A. Donenfeld
2022-05-19 23:44 ` Jens Axboe
2022-05-19 23:13 ` Jason A. Donenfeld
2022-05-19 23:19 ` Jens Axboe
2022-05-19 23:23 ` Jason A. Donenfeld
2022-05-19 23:25 ` Jens Axboe
2022-05-19 23:27 ` Jason A. Donenfeld
2022-05-19 23:57 ` Jens Axboe
2022-05-20 0:00 ` Jason A. Donenfeld
2022-05-20 0:02 ` Jens Axboe
2022-05-20 0:48 ` Jason A. Donenfeld
2022-05-20 0:56 ` Jens Axboe
2022-05-20 1:00 ` Jason A. Donenfeld
2022-05-20 1:05 ` Jens Axboe
2022-05-20 1:10 ` Jens Axboe
2022-05-20 12:43 ` Jason A. Donenfeld
2022-05-20 12:49 ` Jens Axboe
2022-05-20 13:04 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519194838.GA6361@lst.de \
--to=hch@lst.de \
--cc=Jason@zx2c4.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox