From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6316CC433F5 for ; Fri, 20 May 2022 00:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344048AbiETAhT (ORCPT ); Thu, 19 May 2022 20:37:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344047AbiETAhQ (ORCPT ); Thu, 19 May 2022 20:37:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAF3C5F8C5; Thu, 19 May 2022 17:37:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4E0E3B82954; Fri, 20 May 2022 00:37:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13B84C385AA; Fri, 20 May 2022 00:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653007032; bh=0bY4PP/8AE23cA6dggmSHDxNih0qmDn74hKayz9cuko=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=U1ES1eNvNfodef0NPGGoxZi7d1qTexNseH49e3rlgRQh5jtEJjftmwG7JB9Lb6YQQ LbxArY6creVNgumubdeL3PZQunKY5oKiFJF8UNGF8bMZytfLketZNj7Rxx7XTnjiKB jUAyVyw9/ukrKyLWydEnpZjXyhs3hI+IDqoUC9r9mrmRHVmjHR7K7p+oyPnqKpF+tM kmvHuZfWdrLaduvcLAoRfhgPgRdHMoFiV7M6YWusylTzEVq2GONB6iuVecTeKTUIGw 1vHDEtUqPzjC8Uw5PHywUAbqx4HFq8xqKBlaHgn7MG1pIFYhvlFY4mKS5ugWccvRO7 mbcyAcCg4/S1Q== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220519071610.423372-3-wenst@chromium.org> References: <20220519071610.423372-1-wenst@chromium.org> <20220519071610.423372-3-wenst@chromium.org> Subject: Re: [PATCH v3 2/5] clk: mediatek: apmixed: Drop error message from clk_register() failure From: Stephen Boyd Cc: Chen-Yu Tsai , Chun-Jie Chen , Miles Chen , Rex-BC Chen , Matthias Brugger , AngeloGioacchino Del Regno , linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Chen-Yu Tsai , Michael Turquette Date: Thu, 19 May 2022 17:37:09 -0700 User-Agent: alot/0.10 Message-Id: <20220520003712.13B84C385AA@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Chen-Yu Tsai (2022-05-19 00:16:07) > mtk_clk_register_ref2usb_tx() prints an error message if clk_register() > fails. It doesn't if kzalloc() fails though. The caller would then tack > on its own error message to handle this. >=20 > Also, All other clk registration functions in the MediaTek clk library > leave the error message printing to the bulk registration functions, > while the helpers that register individual clks just return error codes. >=20 > Drop the error message that is printed when clk_register() fails in > mtk_clk_register_ref2usb_tx() to make its behavior consistent both > across its failure modes, and with the rest of the driver library. >=20 > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Miles Chen > Reviewed-by: AngeloGioacchino Del Regno > Tested-by: AngeloGioacchino Del Regno > Tested-by: Miles Chen > --- Applied to clk-next