Re: [v1 1/3] arm64: dts: qcom: sc7280: Add drive strength property for secondary MI2S

Matthias Kaehlcke
2022-05-19T15:24:31Z

On Thu, May 19, 2022 at 08:41:17AM +0000, Judy Hsiao wrote:

> Subject: arm64: dts: qcom: sc7280: Add drive strength property for secondary MI2S
>
> Add drive strength property for secondary MI2S on sc7280 based platforms

That's not an accurate description, this patch only adjust settings for
herobrine based boards. This should be reflected at list in the subject.

Besides setting the drive strengths this patch also disables the pulls
on some lines, so maybe better say something like "arm64: dts: qcom:
sc7280: herobrine: Add pinconf settings for mi2s1".

> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 9cb1bc8ed6b5..6d8744e130b0 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -612,6 +612,20 @@ &dp_hot_plug_det {
> bias-disable;
> };
>
> +&mi2s1_data0 {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s1_sclk {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s1_ws {
> + drive-strength = <6>;
> +};
> +
> &pcie1_clkreq_n {
> bias-pull-up;
> drive-strength = <2>;
> --
> 2.36.1.124.g0e6072fb45-goog
>