Re: [PATCH v2] iio: vadc: Fix potential dereference of NULL pointer

刘永志
2022-05-19T16:36:09Z

> -----Original Messages-----
> From: "Kalle Valo" <kvalo@kernel.org>
> Sent Time: 2022-05-19 23:30:51 (Thursday)
> To: "Yongzhi Liu" <lyz_cs@pku.edu.cn>
> Cc: amitkarwar@gmail.com, ganapathi017@gmail.com, sharvari.harisangam@nxp.com, huxinming820@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, fuyq@stu.pku.edu.cn
> Subject: Re: [PATCH v2] iio: vadc: Fix potential dereference of NULL pointer
>
> Yongzhi Liu <lyz_cs@pku.edu.cn> writes:
>
> > The return value of vadc_get_channel() needs to be checked
> > to avoid use of NULL pointer. Fix this by adding the null
> > pointer check on prop.
> >
> > Fixes: 0917de94c ("iio: vadc: Qualcomm SPMI PMIC voltage ADC driver")
> >
> > Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
> > ---
> > drivers/iio/adc/qcom-spmi-vadc.c | 23 ++++++++++++++++++++++-
> > 1 file changed, 22 insertions(+), 1 deletion(-)
>

I'm sorry to send this to linux-wireless by mistake. I will cautiously submit patches later.

> Did you sent this to linux-wireless by mistake?
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches