Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property

Rob Herring
2022-05-23T14:08:23Z

On Sat, May 21, 2022 at 04:05:01PM +0200, Krzysztof Kozlowski wrote:
> On 21/05/2022 00:19, Rob Herring wrote:
> > On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote:
> >> This is a clock-controller binding, so it needs #clock-cells, or
> >> it would be of no use: add that to the list of required properties.
> >>
> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
> >> .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml | 1 +
> >> .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 1 +
> >> .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml | 1 +
> >> .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml | 1 +
> >> .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml | 1 +
> >> 6 files changed, 6 insertions(+)
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> >
> > Wasn't there some discussion about moving these to bindings/clocks/?
> > Maybe that was another one, it's all a blur...
>
> Yes, there was such idea although I am not sure if this is worth by
> itself - messes up with the git history.

There shouldn't be too much history since converting to schema. For just
a move git is smart enough to see across moves.

Rob