From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Xuefeng Li <lixuefeng@loongson.cn>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] MIPS: Modify early_parse_mem()
Date: Mon, 23 May 2022 15:28:52 +0200 [thread overview]
Message-ID: <20220523132852.GA8289@alpha.franken.de> (raw)
In-Reply-To: <c3e2d39f-1691-4065-c1fb-06f4059c3e0c@loongson.cn>
On Mon, May 09, 2022 at 03:30:11PM +0800, Tiezhu Yang wrote:
>
>
> On 03/18/2022 11:05 PM, Tiezhu Yang wrote:
> > Tiezhu Yang (3):
> > MIPS: Return -EINVAL if mem parameter is empty in early_parse_mem()
> > MIPS: Return -EINVAL if mem parameter is invalid in early_parse_mem()
> > MIPS: Use memblock_add_node() in early_parse_mem() under CONFIG_NUMA
> >
> > arch/mips/kernel/setup.c | 35 +++++++++++++++++++++++++++++------
> > 1 file changed, 29 insertions(+), 6 deletions(-)
> >
>
> Hi Thomas,
>
> Any comments? Are you OK with these changes?
first and last patch are ok with me. The second patch changes semantics
for mem=, which I don't want to change. Iirc the latest idea to solve
your problem was to use mem=XX@ syntax to limit detected memory, which
is the preferred way for me, too.
If you want I'll take patch 1 and 3 out of this series.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2022-05-23 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 15:05 [PATCH 0/3] MIPS: Modify early_parse_mem() Tiezhu Yang
2022-03-18 15:05 ` [PATCH 1/3] MIPS: Return -EINVAL if mem parameter is empty in early_parse_mem() Tiezhu Yang
2022-03-18 15:05 ` [PATCH 2/3] MIPS: Return -EINVAL if mem parameter is invalid " Tiezhu Yang
2022-03-18 15:05 ` [PATCH 3/3] MIPS: Use memblock_add_node() in early_parse_mem() under CONFIG_NUMA Tiezhu Yang
2022-03-22 13:19 ` Jiaxun Yang
2022-03-23 2:42 ` Tiezhu Yang
2022-03-24 12:29 ` Jiaxun Yang
2022-05-09 7:30 ` [PATCH 0/3] MIPS: Modify early_parse_mem() Tiezhu Yang
2022-05-23 13:28 ` Thomas Bogendoerfer [this message]
2022-05-24 2:01 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523132852.GA8289@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox