Re: [PATCH 4.14 04/33] Input: stmfts - fix reference leak in stmfts_input_open

Pavel Machek
2022-05-30T10:29:15Z

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

Hi!

> > > From: Zheng Yongjun <zhengyongjun3@huawei.com>
> > >
> > > [ Upstream commit 26623eea0da3476446909af96c980768df07bbd9 ]
> > >
> > > pm_runtime_get_sync() will increment pm usage counter even it
> > > failed. Forgetting to call pm_runtime_put_noidle will result
> > > in reference leak in stmfts_input_open, so we should fix it.
> >
> > This is wrong, AFAICT.
>
> Yes, I think you are right. How about below?

Looks good to me.

> Input: stmfts - do not leave device disabled in stmfts_input_open
>
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> The commit 26623eea0da3 attempted to deal with potential leak of runtime
> PM counter when opening the touchscreen device, however it ended up
> erroneously dropping the counter in the case of successfully enabling the
> device.
>
> Let's address this by using pm_runtime_resume_and_get() and then executing
> pm_runtime_put_sync() only when we fail to send "sense on" command to the
> device.
>
> Fixes: 26623eea0da3 ("Input: stmfts - fix reference leak in stmfts_input_open")

Reviewed-by: Pavel Machek <pavel@denx.de>

Thank you,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]