Re: [PATCH 5.10 07/97] igc: Update I226_K device ID

Pavel Machek
2022-05-25T10:45:10Z

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Hi!

> From: Sasha Neftin <sasha.neftin@intel.com>
>
> commit 79cc8322b6d82747cb63ea464146c0bf5b5a6bc1 upstream.
>
> The device ID for I226_K was incorrectly assigned, update the device
> ID to the correct one.
>
> Fixes: bfa5e98c9de4 ("igc: Add new device ID")

I don't see updating the ID, I see adding an unused define. I don't
think this is suitable for stable. Same thing goes for previous two
patches, they don't really fix anything.

5106 O Greg Kroah ├─>[PATCH 5.10 05/97] igc: Remove _I_PHY_ID checking
5107 O Greg Kroah ├─>[PATCH 5.10 06/97] igc: Remove phy->type checking
5108 Greg Kroah ├─>[PATCH 5.10 07/97] igc: Update I226_K device ID

Best regards,
Pavel

> +++ b/drivers/net/ethernet/intel/igc/igc_hw.h
> @@ -22,6 +22,7 @@
> #define IGC_DEV_ID_I220_V 0x15F7
> #define IGC_DEV_ID_I225_K 0x3100
> #define IGC_DEV_ID_I225_K2 0x3101
> +#define IGC_DEV_ID_I226_K 0x3102
> #define IGC_DEV_ID_I225_LMVP 0x5502
> #define IGC_DEV_ID_I225_IT 0x0D9F
> #define IGC_DEV_ID_I226_LM 0x125B
>

--
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]