From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dan Murphy <dmurphy@ti.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kyle Swenson <kyle.swenson@est.tech>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses in example
Date: Tue, 24 May 2022 13:34:30 -0500 [thread overview]
Message-ID: <20220524183430.GA4134907-robh@kernel.org> (raw)
In-Reply-To: <20220524070815.42997-1-krzysztof.kozlowski@linaro.org>
On Tue, May 24, 2022 at 09:08:14AM +0200, Krzysztof Kozlowski wrote:
> The multi-led node defined address/size cells, so it intended to have
> children with unit addresses.
>
> The second multi-led's reg property defined three LED indexes within one
> reg item, which is not correct - these are three separate items.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v1:
> 1. Correct multi-led unit address as well (Rob).
>
> Cc: Kyle Swenson <kyle.swenson@est.tech>
> ---
> .../devicetree/bindings/leds/leds-lp50xx.yaml | 24 ++++++++++++-------
> 1 file changed, 15 insertions(+), 9 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2022-05-24 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:08 [PATCH v2 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses in example Krzysztof Kozlowski
2022-05-24 7:08 ` [PATCH v2 2/2] dt-bindings: leds: fix indentation in examples Krzysztof Kozlowski
2022-05-24 18:35 ` Rob Herring
2022-05-24 18:34 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524183430.GA4134907-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyle.swenson@est.tech \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sven.schwermer@disruptive-technologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox