From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Krzysztof Kozlowski <krzk@kernel.org>
Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [krzk-github:n/qcom-bwmon-v3 18/22] drivers/opp/core.c:1162 _set_opp() warn: if statement not indented
Date: Wed, 25 May 2022 14:14:39 +0300 [thread overview]
Message-ID: <202205250514.5udea6OJ-lkp@intel.com> (raw)
tree: https://github.com/krzk/linux n/qcom-bwmon-v3
head: f595f77c2d91820ce85df16e278315e522172710
commit: 9dcc827f8b0062cea637d4a5cc449f2b88134266 [18/22] debug
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220525/202205250514.5udea6OJ-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/opp/core.c:1162 _set_opp() warn: if statement not indented
vim +1162 drivers/opp/core.c
386ba854d9f316 drivers/opp/core.c Viresh Kumar 2021-01-21 1140 static int _set_opp(struct device *dev, struct opp_table *opp_table,
386ba854d9f316 drivers/opp/core.c Viresh Kumar 2021-01-21 1141 struct dev_pm_opp *opp, unsigned long freq)
6a0712f6f199e7 drivers/base/power/opp/core.c Viresh Kumar 2016-02-09 1142 {
386ba854d9f316 drivers/opp/core.c Viresh Kumar 2021-01-21 1143 struct dev_pm_opp *old_opp;
f0b88fa4559525 drivers/opp/core.c Viresh Kumar 2021-01-21 1144 int scaling_down, ret;
6a0712f6f199e7 drivers/base/power/opp/core.c Viresh Kumar 2016-02-09 1145
386ba854d9f316 drivers/opp/core.c Viresh Kumar 2021-01-21 1146 if (unlikely(!opp))
386ba854d9f316 drivers/opp/core.c Viresh Kumar 2021-01-21 1147 return _disable_opp_table(dev, opp_table);
aca48b61f96386 drivers/opp/core.c Rajendra Nayak 2020-04-08 1148
81c4d8a3c41488 drivers/opp/core.c Viresh Kumar 2021-01-20 1149 /* Find the currently set OPP if we don't know already */
81c4d8a3c41488 drivers/opp/core.c Viresh Kumar 2021-01-20 1150 if (unlikely(!opp_table->current_opp))
81c4d8a3c41488 drivers/opp/core.c Viresh Kumar 2021-01-20 1151 _find_current_opp(dev, opp_table);
6a0712f6f199e7 drivers/base/power/opp/core.c Viresh Kumar 2016-02-09 1152
81c4d8a3c41488 drivers/opp/core.c Viresh Kumar 2021-01-20 1153 old_opp = opp_table->current_opp;
81c4d8a3c41488 drivers/opp/core.c Viresh Kumar 2021-01-20 1154
81c4d8a3c41488 drivers/opp/core.c Viresh Kumar 2021-01-20 1155 /* Return early if nothing to do */
de04241ab87afc drivers/opp/core.c Jonathan Marek 2021-02-16 1156 if (old_opp == opp && opp_table->current_rate == freq &&
de04241ab87afc drivers/opp/core.c Jonathan Marek 2021-02-16 1157 opp_table->enabled) {
81c4d8a3c41488 drivers/opp/core.c Viresh Kumar 2021-01-20 1158 dev_dbg(dev, "%s: OPPs are same, nothing to do\n", __func__);
386ba854d9f316 drivers/opp/core.c Viresh Kumar 2021-01-21 1159 return 0;
6a0712f6f199e7 drivers/base/power/opp/core.c Viresh Kumar 2016-02-09 1160 }
6a0712f6f199e7 drivers/base/power/opp/core.c Viresh Kumar 2016-02-09 1161
9dcc827f8b0062 drivers/opp/core.c Krzysztof Kozlowski 2022-05-24 @1162 if (old_opp->bandwidth && old_opp->bandwidth[0].peak)
9dcc827f8b0062 drivers/opp/core.c Krzysztof Kozlowski 2022-05-24 1163 dev_err(dev, "%s: switching OPP: Freq %lu -> %lu Hz, Level %u -> %u, Bw %u -> %u\n",
Just go long. Or put the string on a line by itself.
de04241ab87afc drivers/opp/core.c Jonathan Marek 2021-02-16 1164 __func__, opp_table->current_rate, freq, old_opp->level,
de04241ab87afc drivers/opp/core.c Jonathan Marek 2021-02-16 1165 opp->level, old_opp->bandwidth ? old_opp->bandwidth[0].peak : 0,
f0b88fa4559525 drivers/opp/core.c Viresh Kumar 2021-01-21 1166 opp->bandwidth ? opp->bandwidth[0].peak : 0);
f0b88fa4559525 drivers/opp/core.c Viresh Kumar 2021-01-21 1167
f0b88fa4559525 drivers/opp/core.c Viresh Kumar 2021-01-21 1168 scaling_down = _opp_compare_key(old_opp, opp);
f0b88fa4559525 drivers/opp/core.c Viresh Kumar 2021-01-21 1169 if (scaling_down == -1)
f0b88fa4559525 drivers/opp/core.c Viresh Kumar 2021-01-21 1170 scaling_down = 0;
947355850fcb3b drivers/base/power/opp/core.c Viresh Kumar 2016-12-01 1171
ca1b5d77b1c69d drivers/opp/core.c Viresh Kumar 2018-06-14 1172 /* Scaling up? Configure required OPPs before frequency */
f0b88fa4559525 drivers/opp/core.c Viresh Kumar 2021-01-21 1173 if (!scaling_down) {
2c59138c22f17c drivers/opp/core.c Stephan Gerhold 2020-07-30 1174 ret = _set_required_opps(dev, opp_table, opp, true);
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-05-25 11:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205250514.5udea6OJ-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox