* [PATCH] dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property
@ 2022-05-26 1:41 Rob Herring
2022-05-26 2:23 ` Guenter Roeck
2022-06-03 22:17 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2022-05-26 1:41 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Linus Walleij, Corentin Labbe
Cc: linux-watchdog, devicetree, linux-kernel
The 'unevaluatedProperties' schema checks is not fully working and doesn't
catch some cases where there's a $ref to another schema. A fix is pending,
but results in new warnings in examples.
The correct common watchdog property is 'timeout-sec', not 'timeout-secs'.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/watchdog/faraday,ftwdt010.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
index ca9e1beff76b..6ecd429f76b5 100644
--- a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
+++ b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
@@ -55,7 +55,7 @@ examples:
compatible = "faraday,ftwdt010";
reg = <0x41000000 0x1000>;
interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
- timeout-secs = <5>;
+ timeout-sec = <5>;
};
- |
watchdog: watchdog@98500000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property
2022-05-26 1:41 [PATCH] dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property Rob Herring
@ 2022-05-26 2:23 ` Guenter Roeck
2022-06-03 22:17 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2022-05-26 2:23 UTC (permalink / raw)
To: Rob Herring, Wim Van Sebroeck, Krzysztof Kozlowski, Linus Walleij,
Corentin Labbe
Cc: linux-watchdog, devicetree, linux-kernel
On 5/25/22 18:41, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
>
> The correct common watchdog property is 'timeout-sec', not 'timeout-secs'.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Good find.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> .../devicetree/bindings/watchdog/faraday,ftwdt010.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> index ca9e1beff76b..6ecd429f76b5 100644
> --- a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> @@ -55,7 +55,7 @@ examples:
> compatible = "faraday,ftwdt010";
> reg = <0x41000000 0x1000>;
> interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> - timeout-secs = <5>;
> + timeout-sec = <5>;
> };
> - |
> watchdog: watchdog@98500000 {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property
2022-05-26 1:41 [PATCH] dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property Rob Herring
2022-05-26 2:23 ` Guenter Roeck
@ 2022-06-03 22:17 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-06-03 22:17 UTC (permalink / raw)
To: Rob Herring
Cc: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Corentin Labbe, linux-watchdog, devicetree, linux-kernel
On Thu, May 26, 2022 at 3:41 AM Rob Herring <robh@kernel.org> wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
>
> The correct common watchdog property is 'timeout-sec', not 'timeout-secs'.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
This kind of stuff is exactly what we wanted schema to find and fix.
And now it is delivering. Success!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-03 22:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-26 1:41 [PATCH] dt-bindings: watchdog: faraday: Fix typo in example 'timeout-sec' property Rob Herring
2022-05-26 2:23 ` Guenter Roeck
2022-06-03 22:17 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox