Re: [PATCH v2 1/9] dt-bindings: Add compatible for Mali Valhall (JM)

Steven Price
2022-05-26T08:49:24Z

On 25/05/2022 15:57, Alyssa Rosenzweig wrote:
> From the kernel's perspective, (pre-CSF, "Job Manager") Valhall is more
> or less compatible with Bifrost, although they differ to userspace. Add
> a compatible for Valhall to the existing Bifrost bindings documentation.
>
> As the first SoC with a Valhall GPU receiving mainline support, add a
> specific compatible for the MediaTek MT8192, which instantiates a
> Mali-G57.
>
> v2: Change compatible to arm,mali-valhall-jm (Daniel Stone).
>
> Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
> CC: devicetree@vger.kernel.org

Reviewed-by: Steven Price <steven.price@arm.com>

> ---
> .../bindings/gpu/arm,mali-bifrost.yaml | 25 +++++++++++--------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> index 85f8d4764740..78964c140b46 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> @@ -14,16 +14,21 @@ properties:
> pattern: '^gpu@[a-f0-9]+$'
>
> compatible:
> - items:
> - - enum:
> - - amlogic,meson-g12a-mali
> - - mediatek,mt8183-mali
> - - realtek,rtd1619-mali
> - - renesas,r9a07g044-mali
> - - renesas,r9a07g054-mali
> - - rockchip,px30-mali
> - - rockchip,rk3568-mali
> - - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable
> + oneOf:
> + - items:
> + - enum:
> + - amlogic,meson-g12a-mali
> + - mediatek,mt8183-mali
> + - realtek,rtd1619-mali
> + - renesas,r9a07g044-mali
> + - renesas,r9a07g054-mali
> + - rockchip,px30-mali
> + - rockchip,rk3568-mali
> + - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable
> + - items:
> + - enum:
> + - mediatek,mt8192-mali
> + - const: arm,mali-valhall-jm # Mali Valhall GPU model/revision is fully discoverable
>
> reg:
> maxItems: 1