Re: [PATCH v2 4/5] riscv: fix dependency for t-head errata

Guo Ren
2022-05-27T02:50:59Z

Em... This is a limitation to our scenario but seems it okay for
current t-thead SoC products.

Reviewed-by: Guo Ren <guoren@kernel.org>

On Fri, May 27, 2022 at 4:57 AM Heiko Stuebner <heiko@sntech.de> wrote:
>
> alternatives only work correctly on non-xip-kernels and while the
> selected alternative-symbol has the correct dependency the symbol
> selecting it also needs that dependency.
>
> So add the missing dependency to the T-Head errata Kconfig symbol.
>
> Reported-by: kernel test robot <yujie.liu@intel.com>
> Reviewed-by: Guo Ren <guoren@kernel.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/riscv/Kconfig.erratas | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/Kconfig.erratas b/arch/riscv/Kconfig.erratas
> index ebfcd5cc6eaf..457ac72c9b36 100644
> --- a/arch/riscv/Kconfig.erratas
> +++ b/arch/riscv/Kconfig.erratas
> @@ -35,6 +35,7 @@ config ERRATA_SIFIVE_CIP_1200
>
> config ERRATA_THEAD
> bool "T-HEAD errata"
> + depends on !XIP_KERNEL
> select RISCV_ALTERNATIVE
> help
> All T-HEAD errata Kconfig depend on this Kconfig. Disabling
> --
> 2.35.1
>

--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/