Re: [PATCH v2 0/5] riscv: some svpbmt fixes

Heiko Stübner
2022-06-17T07:13:49Z

Hi Palmer,

Am Freitag, 17. Juni 2022, 01:03:32 CEST schrieb Palmer Dabbelt:
> On Thu, 26 May 2022 13:56:41 PDT (-0700), heiko@sntech.de wrote:
> > Some additionals comments and notes from autobuilders received
> > after the series got applied, warranted some changes.
> >
> > So this is a small collection of cleanups for the svpbmt v10 series.
> >
> > changes in v2:
> > - add Guo's Review
> > - add patch dropping the use of function pointers in code
> > that can run before relocation
> >
> > Heiko Stuebner (5):
> > riscv: drop cpufeature_apply_feature tracking variable
> > riscv: Improve description for RISCV_ISA_SVPBMT Kconfig symbol
> > riscv: make patch-function pointer more generic in
> > cpu_manufacturer_info struct
> > riscv: fix dependency for t-head errata
> > riscv: remove usage of function-pointers from cpufeatures and t-head
> > errata
> >
> > arch/riscv/Kconfig | 9 ++++++--
> > arch/riscv/Kconfig.erratas | 1 +
> > arch/riscv/errata/thead/errata.c | 38 ++++++++++----------------------
> > arch/riscv/kernel/alternative.c | 18 +++++++--------
> > arch/riscv/kernel/cpufeature.c | 37 +++++++++----------------------
> > 5 files changed, 40 insertions(+), 63 deletions(-)
>
> IMO only three of these are actually fixes, the rest are cleanups. I've
> got ahead and put everything on a branch, with
>
> riscv: Improve description for RISCV_ISA_SVPBMT Kconfig symbol
> riscv: drop cpufeature_apply_feature tracking variable
> riscv: fix dependency for t-head errata
>
> first. Those are on fixes, the whole thing is in for-next.

thanks a lot.

For the fixes I think Nathan's "riscv: Fix ALT_THEAD_PMA's asm parameters" [0]
would also be quite important.

Heiko

[0] https://lore.kernel.org/r/20220518184529.454008-1-nathan@kernel.org