public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: Eric Van Hensbergen <ericvh@gmail.com>,
	Latchesar Ionkov <lucho@ionkov.net>,
	Dominique Martinet <asmadeus@codewreck.org>
Cc: Christian Schoenebeck <linux_oss@crudebyte.com>,
	Jianyong Wu <jianyong.wu@arm.com>,
	v9fs-developer@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/5] 9p: Fix refcounting and improve readability in lookup
Date: Thu, 26 May 2022 18:59:58 -0500	[thread overview]
Message-ID: <20220527000003.355812-1-tyhicks@linux.microsoft.com> (raw)

v2:
- Simplified the first patch, by removing code cleanups, to reduce churn
  and minimize regression potential in stable trees
  + The resulting changes are *identical* to the v1 submission when
    patches 1, 2, and 3 are applied
- Added patches 4 and 5 which are additional, minor code cleanups
v1: https://lore.kernel.org/lkml/20220525182530.266068-1-tyhicks@linux.microsoft.com/

The primary motivation for this series is patch #1 which fixes a
refcounting issue in the path walking code of
v9fs_fid_lookup_with_uid(). Userspace can cause fids, which are created
for use during lookup, to not be clunked and make the mount unusable.

The remaining patches are code cleanups to improve readability. They're
not critical.

I tested v1 and v2 by running fstests against 9p inside of QEMU to
ensure that the results were the same as without my changes applied. I
also backported patch #1 of v2 to linux-5.15.y (v5.15.32) and ensured
that the 'fid not clunked' issue did not occur when running against the
Windows Subsystem for Linux (WSL) 9p server.

Tyler

Tyler Hicks (5):
  9p: Fix refcounting during full path walks for fid lookups
  9p: Track the root fid with its own variable during lookups
  9p: Make the path walk logic more clear about when cloning is required
  9p: Remove unnecessary variable for old fids while walking from
    d_parent
  9p: Fix minor typo in code comment

 fs/9p/fid.c | 50 ++++++++++++++++++++++----------------------------
 1 file changed, 22 insertions(+), 28 deletions(-)

-- 
2.25.1


             reply	other threads:[~2022-05-27  0:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 23:59 Tyler Hicks [this message]
2022-05-26 23:59 ` [PATCH v2 1/5] 9p: Fix refcounting during full path walks for fid lookups Tyler Hicks
2022-05-30 17:14   ` Christian Schoenebeck
2022-05-31 14:28     ` Tyler Hicks
2022-06-01 14:28       ` Christian Schoenebeck
2022-06-07  3:41         ` Tyler Hicks
2022-06-09 12:44           ` Christian Schoenebeck
2022-06-11 12:46             ` Dominique Martinet
2022-06-11 23:17   ` Dominique Martinet
2022-06-13 19:38     ` Tyler Hicks
2022-05-27  0:00 ` [PATCH v2 2/5] 9p: Track the root fid with its own variable during lookups Tyler Hicks
2022-05-27  0:00 ` [PATCH v2 3/5] 9p: Make the path walk logic more clear about when cloning is required Tyler Hicks
2022-05-27  0:00 ` [PATCH v2 4/5] 9p: Remove unnecessary variable for old fids while walking from d_parent Tyler Hicks
2022-05-27  0:00 ` [PATCH v2 5/5] 9p: Fix minor typo in code comment Tyler Hicks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220527000003.355812-1-tyhicks@linux.microsoft.com \
    --to=tyhicks@linux.microsoft.com \
    --cc=asmadeus@codewreck.org \
    --cc=ericvh@gmail.com \
    --cc=jianyong.wu@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox