* [PATCH] octeontx2-af: fix operand size in bitwise operation
@ 2022-05-27 7:59 Shijith Thotton
2022-05-28 0:39 ` Jakub Kicinski
2022-06-30 10:54 ` [PATCH v2] " Shijith Thotton
0 siblings, 2 replies; 4+ messages in thread
From: Shijith Thotton @ 2022-05-27 7:59 UTC (permalink / raw)
To: Arnaud Ebalard, Herbert Xu, Boris Brezillon
Cc: Shijith Thotton, linux-crypto, jerinj, sgoutham, Linu Cherian,
Geetha sowjanya, hariprasad, Subbaraya Sundeep, David S. Miller,
Jakub Kicinski, Paolo Abeni,
open list:MARVELL OCTEONTX2 RVU ADMIN FUNCTION DRIVER, open list
Made size of operands same in bitwise operations.
The patch fixes the klocwork issue, operands in a bitwise operation have
different size at line 375 and 483.
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c
index a79201a9a6f0..d08cddb651fb 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c
@@ -17,7 +17,7 @@
#define PCI_DEVID_OTX2_CPT10K_PF 0xA0F2
/* Length of initial context fetch in 128 byte words */
-#define CPT_CTX_ILEN 2
+#define CPT_CTX_ILEN 2ULL
#define cpt_get_eng_sts(e_min, e_max, rsp, etype) \
({ \
@@ -480,7 +480,7 @@ static int cpt_inline_ipsec_cfg_inbound(struct rvu *rvu, int blkaddr, u8 cptlf,
*/
if (!is_rvu_otx2(rvu)) {
val = (ilog2(NIX_CHAN_CPT_X2P_MASK + 1) << 16);
- val |= rvu->hw->cpt_chan_base;
+ val |= (u64)rvu->hw->cpt_chan_base;
rvu_write64(rvu, blkaddr, CPT_AF_X2PX_LINK_CFG(0), val);
rvu_write64(rvu, blkaddr, CPT_AF_X2PX_LINK_CFG(1), val);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] octeontx2-af: fix operand size in bitwise operation
2022-05-27 7:59 [PATCH] octeontx2-af: fix operand size in bitwise operation Shijith Thotton
@ 2022-05-28 0:39 ` Jakub Kicinski
2022-06-30 10:54 ` [PATCH v2] " Shijith Thotton
1 sibling, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-05-28 0:39 UTC (permalink / raw)
To: Shijith Thotton
Cc: Arnaud Ebalard, Herbert Xu, Boris Brezillon, linux-crypto, jerinj,
sgoutham, Linu Cherian, Geetha sowjanya, hariprasad,
Subbaraya Sundeep, David S. Miller, Paolo Abeni,
open list:MARVELL OCTEONTX2 RVU ADMIN FUNCTION DRIVER, open list
On Fri, 27 May 2022 13:29:28 +0530 Shijith Thotton wrote:
> Made size of operands same in bitwise operations.
>
> The patch fixes the klocwork issue, operands in a bitwise operation
> have different size at line 375 and 483.
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
# Form letter - net-next is closed
We have already sent the networking pull request for 5.19
and therefore net-next is closed for new drivers, features,
code refactoring and optimizations. We are currently accepting
bug fixes only.
Please repost when net-next reopens after 5.19-rc1 is cut.
RFC patches sent for review only are obviously welcome at any time.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] octeontx2-af: fix operand size in bitwise operation
2022-05-27 7:59 [PATCH] octeontx2-af: fix operand size in bitwise operation Shijith Thotton
2022-05-28 0:39 ` Jakub Kicinski
@ 2022-06-30 10:54 ` Shijith Thotton
2022-07-02 2:20 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Shijith Thotton @ 2022-06-30 10:54 UTC (permalink / raw)
To: Arnaud Ebalard, Herbert Xu, Boris Brezillon
Cc: Shijith Thotton, linux-crypto, jerinj, sgoutham, Linu Cherian,
Geetha sowjanya, hariprasad, Subbaraya Sundeep, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni,
open list:MARVELL OCTEONTX2 RVU ADMIN FUNCTION DRIVER, open list
Made size of operands same in bitwise operations.
The patch fixes the klocwork issue, operands in a bitwise operation have
different size at line 375 and 483.
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
v2:
* Rebased.
drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c
index a9da85e418a4..38bbae5d9ae0 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c
@@ -17,7 +17,7 @@
#define PCI_DEVID_OTX2_CPT10K_PF 0xA0F2
/* Length of initial context fetch in 128 byte words */
-#define CPT_CTX_ILEN 2
+#define CPT_CTX_ILEN 2ULL
#define cpt_get_eng_sts(e_min, e_max, rsp, etype) \
({ \
@@ -480,7 +480,7 @@ static int cpt_inline_ipsec_cfg_inbound(struct rvu *rvu, int blkaddr, u8 cptlf,
*/
if (!is_rvu_otx2(rvu)) {
val = (ilog2(NIX_CHAN_CPT_X2P_MASK + 1) << 16);
- val |= rvu->hw->cpt_chan_base;
+ val |= (u64)rvu->hw->cpt_chan_base;
rvu_write64(rvu, blkaddr, CPT_AF_X2PX_LINK_CFG(0), val);
rvu_write64(rvu, blkaddr, CPT_AF_X2PX_LINK_CFG(1), val);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] octeontx2-af: fix operand size in bitwise operation
2022-06-30 10:54 ` [PATCH v2] " Shijith Thotton
@ 2022-07-02 2:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-02 2:20 UTC (permalink / raw)
To: Shijith Thotton
Cc: arno, herbert, bbrezillon, linux-crypto, jerinj, sgoutham,
lcherian, gakula, hkelam, sbhatta, davem, edumazet, kuba, pabeni,
netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 30 Jun 2022 16:24:31 +0530 you wrote:
> Made size of operands same in bitwise operations.
>
> The patch fixes the klocwork issue, operands in a bitwise operation have
> different size at line 375 and 483.
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
>
> [...]
Here is the summary with links:
- [v2] octeontx2-af: fix operand size in bitwise operation
https://git.kernel.org/netdev/net-next/c/b14056914357
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-02 2:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-27 7:59 [PATCH] octeontx2-af: fix operand size in bitwise operation Shijith Thotton
2022-05-28 0:39 ` Jakub Kicinski
2022-06-30 10:54 ` [PATCH v2] " Shijith Thotton
2022-07-02 2:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).