public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Sumit Saxena <sumit.saxena@broadcom.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Himanshu Madhani <himanshu.madhani@oracle.com>
Subject: drivers/scsi/mpi3mr/mpi3mr_app.c:1230: warning: expecting prototype for adapter_state_show(). Prototype was for adp_state_show() instead
Date: Sat, 28 May 2022 01:21:17 +0800	[thread overview]
Message-ID: <202205280136.fIV879pm-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7e284070abe53d448517b80493863595af4ab5f0
commit: 986d6bad2103fb24bd886aad455245ace168c984 scsi: mpi3mr: Expose adapter state to sysfs
date:   4 weeks ago
config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220528/202205280136.fIV879pm-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=986d6bad2103fb24bd886aad455245ace168c984
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 986d6bad2103fb24bd886aad455245ace168c984
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/scsi/mpi3mr/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/mpi3mr/mpi3mr_app.c:641: warning: Function parameter or member 'reply_payload_rcv_len' not described in 'mpi3mr_bsg_process_mpt_cmds'
   drivers/scsi/mpi3mr/mpi3mr_app.c:1147: warning: Function parameter or member 'mrioc' not described in 'mpi3mr_bsg_exit'
   drivers/scsi/mpi3mr/mpi3mr_app.c:1181: warning: Function parameter or member 'mrioc' not described in 'mpi3mr_bsg_init'
>> drivers/scsi/mpi3mr/mpi3mr_app.c:1230: warning: expecting prototype for adapter_state_show(). Prototype was for adp_state_show() instead


vim +1230 drivers/scsi/mpi3mr/mpi3mr_app.c

  1218	
  1219	/**
  1220	 * adapter_state_show - SysFS callback for adapter state show
  1221	 * @dev: class device
  1222	 * @attr: Device attributes
  1223	 * @buf: Buffer to copy
  1224	 *
  1225	 * Return: snprintf() return after copying adapter state
  1226	 */
  1227	static ssize_t
  1228	adp_state_show(struct device *dev, struct device_attribute *attr,
  1229		char *buf)
> 1230	{
  1231		struct Scsi_Host *shost = class_to_shost(dev);
  1232		struct mpi3mr_ioc *mrioc = shost_priv(shost);
  1233		enum mpi3mr_iocstate ioc_state;
  1234		uint8_t adp_state;
  1235	
  1236		ioc_state = mpi3mr_get_iocstate(mrioc);
  1237		if (ioc_state == MRIOC_STATE_UNRECOVERABLE)
  1238			adp_state = MPI3MR_BSG_ADPSTATE_UNRECOVERABLE;
  1239		else if ((mrioc->reset_in_progress) || (mrioc->stop_bsgs))
  1240			adp_state = MPI3MR_BSG_ADPSTATE_IN_RESET;
  1241		else if (ioc_state == MRIOC_STATE_FAULT)
  1242			adp_state = MPI3MR_BSG_ADPSTATE_FAULT;
  1243		else
  1244			adp_state = MPI3MR_BSG_ADPSTATE_OPERATIONAL;
  1245	
  1246		return snprintf(buf, PAGE_SIZE, "%u\n", adp_state);
  1247	}
  1248	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-05-27 17:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202205280136.fIV879pm-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=himanshu.madhani@oracle.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sumit.saxena@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox