From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E21F3C4167E for ; Mon, 30 May 2022 13:47:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238442AbiE3NpX (ORCPT ); Mon, 30 May 2022 09:45:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237376AbiE3Ngl (ORCPT ); Mon, 30 May 2022 09:36:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 422578A31F; Mon, 30 May 2022 06:30:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BBAE760F24; Mon, 30 May 2022 13:30:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2960C3411C; Mon, 30 May 2022 13:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653917403; bh=0E85koPt9s3yDz6YPmB3DHfWULhdIVxSy0dmM2NsFl8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NHgyP1zSgLMOrBN8tuh5h/RxIqsHSbdcB5TCwUjn2wupL6lyu0gWvOpwJS8S7oqId gvolM4ZHjxLQ4krz+4oTcrLNaSO5BzFdFb012N6h9qL/CiKAYtdpCBOL7r2mgN8gpZ xziMpszqvYHDpGf6081wYLyyHsCL0GBzbTWWOzC59bQy9xFtI/Q1m+l6WHy4nBX7CX mHYKy3H5bOrwj3zpEsZN4eyKIaJpJO8ygeGK93FAuS3W97ZLgEy9xmHI0paMu9/zRD TBADwAqZOpzQkBourualNSPpvZHRtfMQusuTMbwaZDqHI/tEdkIB8Zw6tpGxaY6fQu lgqcAffcJ6f9A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Jason A. Donenfeld" , Andrew Morton , Stafford Horne , Sasha Levin , rostedt@goodmis.org, mhiramat@kernel.org, vbabka@suse.cz, ahalaney@redhat.com, mark-pk.tsai@mediatek.com, peterz@infradead.org Subject: [PATCH AUTOSEL 5.18 124/159] init: call time_init() before rand_initialize() Date: Mon, 30 May 2022 09:23:49 -0400 Message-Id: <20220530132425.1929512-124-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220530132425.1929512-1-sashal@kernel.org> References: <20220530132425.1929512-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Jason A. Donenfeld" [ Upstream commit fe222a6ca2d53c38433cba5d3be62a39099e708e ] Currently time_init() is called after rand_initialize(), but rand_initialize() makes use of the timer on various platforms, and sometimes this timer needs to be initialized by time_init() first. In order for random_get_entropy() to not return zero during early boot when it's potentially used as an entropy source, reverse the order of these two calls. The block doing random initialization was right before time_init() before, so changing the order shouldn't have any complicated effects. Cc: Andrew Morton Reviewed-by: Stafford Horne Signed-off-by: Jason A. Donenfeld Signed-off-by: Sasha Levin --- init/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/init/main.c b/init/main.c index 98182c3c2c4b..92783732a36f 100644 --- a/init/main.c +++ b/init/main.c @@ -1035,11 +1035,13 @@ asmlinkage __visible void __init __no_sanitize_address start_kernel(void) softirq_init(); timekeeping_init(); kfence_init(); + time_init(); /* * For best initial stack canary entropy, prepare it after: * - setup_arch() for any UEFI RNG entropy and boot cmdline access * - timekeeping_init() for ktime entropy used in rand_initialize() + * - time_init() for making random_get_entropy() work on some platforms * - rand_initialize() to get any arch-specific entropy like RDRAND * - add_latent_entropy() to get any latent entropy * - adding command line entropy @@ -1049,7 +1051,6 @@ asmlinkage __visible void __init __no_sanitize_address start_kernel(void) add_device_randomness(command_line, strlen(command_line)); boot_init_stack_canary(); - time_init(); perf_event_init(); profile_init(); call_function_init(); -- 2.35.1