Re: [PATCH AUTOSEL 5.17 128/135] hwmon: Make chip parameter for with_info API mandatory

Guenter Roeck
2022-05-31T03:00:59Z

On 5/30/22 19:38, Bagas Sanjaya wrote:
> On 5/30/22 21:27, Guenter Roeck wrote:
>> On 5/30/22 06:31, Sasha Levin wrote:
>>> From: Guenter Roeck <linux@roeck-us.net>
>>>
>>> [ Upstream commit ddaefa209c4ac791c1262e97c9b2d0440c8ef1d5 ]
>>>
>>> Various attempts were made recently to "convert" the old
>>> hwmon_device_register() API to devm_hwmon_device_register_with_info()
>>> by just changing the function name without actually converting the
>>> driver. Prevent this from happening by making the 'chip' parameter of
>>> devm_hwmon_device_register_with_info() mandatory.
>>>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>>
>> This patch should not be backported. It is only relevant for new
>> kernel releases, and may have adverse affect if applied to older
>> kernels.
>
> So this patch is meant to be backported to 5.18 only, right?
>

I said "do not backport". I specifically asked not to backport
this patch. It does not include Cc: stable, and it does not
include a Fixes: tag. I even said "... may have adverse affect
if applied to older kernels".

I have no idea how that can be interpreted as "backport to 5.18".
Did I miss the explicit "do not backport to 5.18 ?" If so, my bad.

Ok, here it is a more explicit request:

Do not backport this patch to 5.18.y, 5.17.y, 5.15.y, 5.10.y, 5.4.y,
4.19.y, 4.14.y, 4.9.y, or any other stable release.

Guenter