From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: jianghaoran <jianghaoran@kylinos.cn>,
Jakub Kicinski <kuba@kernel.org>, Sasha Levin <sashal@kernel.org>,
davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 5.4 27/55] ipv6: Don't send rs packets to the interface of ARPHRD_TUNNEL
Date: Mon, 30 May 2022 09:46:33 -0400 [thread overview]
Message-ID: <20220530134701.1935933-27-sashal@kernel.org> (raw)
In-Reply-To: <20220530134701.1935933-1-sashal@kernel.org>
From: jianghaoran <jianghaoran@kylinos.cn>
[ Upstream commit b52e1cce31ca721e937d517411179f9196ee6135 ]
ARPHRD_TUNNEL interface can't process rs packets
and will generate TX errors
ex:
ip tunnel add ethn mode ipip local 192.168.1.1 remote 192.168.1.2
ifconfig ethn x.x.x.x
ethn: flags=209<UP,POINTOPOINT,RUNNING,NOARP> mtu 1480
inet x.x.x.x netmask 255.255.255.255 destination x.x.x.x
inet6 fe80::5efe:ac1e:3cdb prefixlen 64 scopeid 0x20<link>
tunnel txqueuelen 1000 (IPIP Tunnel)
RX packets 0 bytes 0 (0.0 B)
RX errors 0 dropped 0 overruns 0 frame 0
TX packets 0 bytes 0 (0.0 B)
TX errors 3 dropped 0 overruns 0 carrier 0 collisions 0
Signed-off-by: jianghaoran <jianghaoran@kylinos.cn>
Link: https://lore.kernel.org/r/20220429053802.246681-1-jianghaoran@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
net/ipv6/addrconf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index efea88fb3cd5..e29553e4f4ee 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -4202,7 +4202,8 @@ static void addrconf_dad_completed(struct inet6_ifaddr *ifp, bool bump_id,
send_rs = send_mld &&
ipv6_accept_ra(ifp->idev) &&
ifp->idev->cnf.rtr_solicits != 0 &&
- (dev->flags&IFF_LOOPBACK) == 0;
+ (dev->flags & IFF_LOOPBACK) == 0 &&
+ (dev->type != ARPHRD_TUNNEL);
read_unlock_bh(&ifp->idev->lock);
/* While dad is in progress mld report's source address is in6_addrany.
--
2.35.1
next prev parent reply other threads:[~2022-05-30 14:31 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 13:46 [PATCH AUTOSEL 5.4 01/55] drm/virtio: fix NULL pointer dereference in virtio_gpu_conn_get_modes Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 02/55] mwifiex: add mutex lock for call in mwifiex_dfs_chan_sw_work_queue Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 03/55] b43legacy: Fix assigning negative value to unsigned variable Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 04/55] b43: " Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 05/55] ipw2x00: Fix potential NULL dereference in libipw_xmit() Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 06/55] ipv6: fix locking issues with loops over idev->addr_list Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 07/55] fbcon: Consistently protect deferred_takeover with console_lock() Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 08/55] ACPICA: Avoid cache flush inside virtual machines Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 09/55] drm/komeda: return early if drm_universal_plane_init() fails Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 10/55] ALSA: jack: Access input_dev under mutex Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 11/55] spi: spi-rspi: Remove setting {src,dst}_{addr,addr_width} based on DMA direction Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 12/55] tools/power turbostat: fix ICX DRAM power numbers Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 13/55] drm/amd/pm: fix double free in si_parse_power_table() Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 14/55] ath9k: fix QCA9561 PA bias level Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 15/55] media: venus: hfi: avoid null dereference in deinit Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 16/55] media: pci: cx23885: Fix the error handling in cx23885_initdev() Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 17/55] media: cx25821: Fix the warning when removing the module Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 18/55] md/bitmap: don't set sb values if can't pass sanity check Sasha Levin
2022-06-01 21:36 ` John Stoffel
2022-06-05 13:27 ` Sasha Levin
2022-06-05 14:01 ` John Stoffel
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 19/55] mmc: jz4740: Apply DMA engine limits to maximum segment size Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 20/55] drm/sun4i: Add support for D1 TCONs Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 21/55] scsi: megaraid: Fix error check return value of register_chrdev() Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 22/55] arm64/sme: Add ID_AA64SMFR0_EL1 to __read_sysreg_by_encoding() Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 23/55] drm/plane: Move range check for format_count earlier Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 24/55] drm/amd/pm: fix the compile warning Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 25/55] arm64: compat: Do not treat syscall number as ESR_ELx for a bad syscall Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 26/55] drm: msm: fix error check return value of irq_of_parse_and_map() Sasha Levin
2022-05-30 13:46 ` Sasha Levin [this message]
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 28/55] net/mlx5: fs, delete the FTE when there are no rules attached to it Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 29/55] ASoC: dapm: Don't fold register value changes into notifications Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 30/55] mlxsw: spectrum_dcb: Do not warn about priority changes Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 31/55] drm/amdgpu/ucode: Remove firmware load type check in amdgpu_ucode_free_bo Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 32/55] HID: bigben: fix slab-out-of-bounds Write in bigben_probe Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 33/55] ASoC: tscs454: Add endianness flag in snd_soc_component_driver Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 34/55] net: remove two BUG() from skb_checksum_help() Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 35/55] s390/preempt: disable __preempt_count_add() optimization for PROFILE_ALL_BRANCHES Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 36/55] spi: stm32-qspi: Fix wait_cmd timeout in APM mode Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 37/55] dma-debug: change allocation mode from GFP_NOWAIT to GFP_ATIOMIC Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 38/55] ACPI: PM: Block ASUS B1400CEAE from suspend to idle by default Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 39/55] ipmi:ssif: Check for NULL msg when handling events and messages Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 40/55] ipmi: Fix pr_fmt to avoid compilation issues Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 41/55] rtlwifi: Use pr_warn instead of WARN_ONCE Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 42/55] media: coda: limit frame interval enumeration to supported encoder frame sizes Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 43/55] media: cec-adap.c: fix is_configuring state Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 44/55] openrisc: start CPU timer early in boot Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 45/55] nvme-pci: fix a NULL pointer dereference in nvme_alloc_admin_tags Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 46/55] ASoC: rt5645: Fix errorenous cleanup order Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 47/55] nbd: Fix hung on disconnect request if socket is closed before Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 48/55] net: phy: micrel: Allow probing without .driver_data Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 49/55] media: exynos4-is: Fix compile warning Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 50/55] ASoC: max98357a: remove dependency on GPIOLIB Sasha Levin
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 51/55] ARM: 9201/1: spectre-bhb: rely on linker to emit cross-section literal loads Sasha Levin
2022-05-30 13:52 ` Ard Biesheuvel
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 52/55] hwmon: Make chip parameter for with_info API mandatory Sasha Levin
2022-05-30 14:29 ` Guenter Roeck
2022-05-30 13:46 ` [PATCH AUTOSEL 5.4 53/55] rxrpc: Return an error to sendmsg if call failed Sasha Levin
2022-05-30 13:47 ` [PATCH AUTOSEL 5.4 54/55] eth: tg3: silence the GCC 12 array-bounds warning Sasha Levin
2022-05-30 13:47 ` [PATCH AUTOSEL 5.4 55/55] selftests/bpf: fix btf_dump/btf_dump due to recent clang change Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220530134701.1935933-27-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jianghaoran@kylinos.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox