From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Lv Ruyi <lv.ruyi@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Sasha Levin <sashal@kernel.org>,
kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com,
megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org
Subject: [PATCH AUTOSEL 4.9 11/24] scsi: megaraid: Fix error check return value of register_chrdev()
Date: Mon, 30 May 2022 09:51:58 -0400 [thread overview]
Message-ID: <20220530135211.1937674-11-sashal@kernel.org> (raw)
In-Reply-To: <20220530135211.1937674-1-sashal@kernel.org>
From: Lv Ruyi <lv.ruyi@zte.com.cn>
[ Upstream commit c5acd61dbb32b6bda0f3a354108f2b8dcb788985 ]
If major equals 0, register_chrdev() returns an error code when it fails.
This function dynamically allocates a major and returns its number on
success, so we should use "< 0" to check it instead of "!".
Link: https://lore.kernel.org/r/20220418105755.2558828-1-lv.ruyi@zte.com.cn
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/scsi/megaraid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 2cbfec6a7466..2f7132edcd3f 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -4705,7 +4705,7 @@ static int __init megaraid_init(void)
* major number allocation.
*/
major = register_chrdev(0, "megadev_legacy", &megadev_fops);
- if (!major) {
+ if (major < 0) {
printk(KERN_WARNING
"megaraid: failed to register char device\n");
}
--
2.35.1
next prev parent reply other threads:[~2022-05-30 14:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 13:51 [PATCH AUTOSEL 4.9 01/24] drm/virtio: fix NULL pointer dereference in virtio_gpu_conn_get_modes Sasha Levin
2022-05-30 13:51 ` [PATCH AUTOSEL 4.9 02/24] mwifiex: add mutex lock for call in mwifiex_dfs_chan_sw_work_queue Sasha Levin
2022-05-30 13:51 ` [PATCH AUTOSEL 4.9 03/24] b43legacy: Fix assigning negative value to unsigned variable Sasha Levin
2022-05-30 13:51 ` [PATCH AUTOSEL 4.9 04/24] b43: " Sasha Levin
2022-05-30 13:51 ` [PATCH AUTOSEL 4.9 05/24] ipw2x00: Fix potential NULL dereference in libipw_xmit() Sasha Levin
2022-05-30 13:51 ` [PATCH AUTOSEL 4.9 06/24] ACPICA: Avoid cache flush inside virtual machines Sasha Levin
2022-05-30 13:51 ` [PATCH AUTOSEL 4.9 07/24] ALSA: jack: Access input_dev under mutex Sasha Levin
2022-05-30 13:51 ` [PATCH AUTOSEL 4.9 08/24] drm/amd/pm: fix double free in si_parse_power_table() Sasha Levin
2022-05-30 13:51 ` [PATCH AUTOSEL 4.9 09/24] ath9k: fix QCA9561 PA bias level Sasha Levin
2022-05-30 13:51 ` [PATCH AUTOSEL 4.9 10/24] media: cx25821: Fix the warning when removing the module Sasha Levin
2022-05-30 13:51 ` Sasha Levin [this message]
2022-05-30 13:51 ` [PATCH AUTOSEL 4.9 12/24] drm/amd/pm: fix the compile warning Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 13/24] ipv6: Don't send rs packets to the interface of ARPHRD_TUNNEL Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 14/24] ASoC: dapm: Don't fold register value changes into notifications Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 15/24] net: remove two BUG() from skb_checksum_help() Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 16/24] dma-debug: change allocation mode from GFP_NOWAIT to GFP_ATIOMIC Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 17/24] ipmi:ssif: Check for NULL msg when handling events and messages Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 18/24] openrisc: start CPU timer early in boot Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 19/24] nvme-pci: fix a NULL pointer dereference in nvme_alloc_admin_tags Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 20/24] ASoC: rt5645: Fix errorenous cleanup order Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 21/24] media: exynos4-is: Fix compile warning Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 22/24] ARM: 9201/1: spectre-bhb: rely on linker to emit cross-section literal loads Sasha Levin
2022-05-30 13:53 ` Ard Biesheuvel
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 23/24] rxrpc: Return an error to sendmsg if call failed Sasha Levin
2022-05-30 13:52 ` [PATCH AUTOSEL 4.9 24/24] eth: tg3: silence the GCC 12 array-bounds warning Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220530135211.1937674-11-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=sumit.saxena@broadcom.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox