* [PATCH v1 1/1] iio: dac: ad5592r: Get rid of OF specifics
@ 2022-05-31 13:53 Andy Shevchenko
2022-06-03 17:28 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2022-05-31 13:53 UTC (permalink / raw)
To: Jonathan Cameron, linux-iio, linux-kernel
Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Andy Shevchenko
Use dev_fwnode() instead of direct OF node dereference when checking
for regulator API error code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/dac/ad5592r-base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
index 4434c1b2a322..7a9b5fc1e579 100644
--- a/drivers/iio/dac/ad5592r-base.c
+++ b/drivers/iio/dac/ad5592r-base.c
@@ -603,7 +603,7 @@ int ad5592r_probe(struct device *dev, const char *name,
st->reg = devm_regulator_get_optional(dev, "vref");
if (IS_ERR(st->reg)) {
- if ((PTR_ERR(st->reg) != -ENODEV) && dev->of_node)
+ if ((PTR_ERR(st->reg) != -ENODEV) && dev_fwnode(dev))
return PTR_ERR(st->reg);
st->reg = NULL;
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] iio: dac: ad5592r: Get rid of OF specifics
2022-05-31 13:53 [PATCH v1 1/1] iio: dac: ad5592r: Get rid of OF specifics Andy Shevchenko
@ 2022-06-03 17:28 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-06-03 17:28 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jonathan Cameron, linux-iio, linux-kernel, Lars-Peter Clausen,
Michael Hennerich
On Tue, 31 May 2022 16:53:20 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Use dev_fwnode() instead of direct OF node dereference when checking
> for regulator API error code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied
> ---
> drivers/iio/dac/ad5592r-base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
> index 4434c1b2a322..7a9b5fc1e579 100644
> --- a/drivers/iio/dac/ad5592r-base.c
> +++ b/drivers/iio/dac/ad5592r-base.c
> @@ -603,7 +603,7 @@ int ad5592r_probe(struct device *dev, const char *name,
>
> st->reg = devm_regulator_get_optional(dev, "vref");
> if (IS_ERR(st->reg)) {
> - if ((PTR_ERR(st->reg) != -ENODEV) && dev->of_node)
> + if ((PTR_ERR(st->reg) != -ENODEV) && dev_fwnode(dev))
> return PTR_ERR(st->reg);
>
> st->reg = NULL;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-03 17:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-31 13:53 [PATCH v1 1/1] iio: dac: ad5592r: Get rid of OF specifics Andy Shevchenko
2022-06-03 17:28 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox