Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller

Rob Herring
2022-05-26T12:46:36Z

On Thu, May 26, 2022 at 4:02 AM Kunihiko Hayashi
<hayashi.kunihiko@socionext.com> wrote:
>
> Hi Rob,
>
> On 2022/05/26 6:01, Rob Herring wrote:
> > The Socionext interrupt controller internal to the the PCI block isn't
> > documented which causes warnings when unevaluatedProperties check is
> > also fixed. Add the 'interrupt-controller' child node and properties and
> > fixup the example so that interrupt properties can be parsed.
>
> Surely internal interrupt controller isn't described, and should be documented.
> And the child node name "legacy-interrupt-controller" also should be fixed.
>
> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Thanks.

>
> BTW I can't reproduce such warnings with my environment.
> Can you show the command line to reproduce the warnings?

"causes warnings when unevaluatedProperties check is also fixed"

You won't. I have a fix in dtschema pending, but first all the
warnings that appear need to be fixed.

Rob