Re: [PATCH v1 1/3] iio: adc: meson_saradc: Convert to use dev_err_probe()

Martin Blumenstingl
2022-05-31T21:55:08Z

Hi Andy,

overall this is looking great - thank you for this patch!

On Tue, May 31, 2022 at 11:18 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
[...]
> + if (IS_ERR(priv->tsc_regmap))
> + return dev_err_probe(dev, PTR_ERR(priv->tsc_regmap), "failed to get amlogic,hhi-sysctrl regmap\n");
checkpatch complains:
WARNING: line length of 115 exceeds 100 columns
#44: FILE: drivers/iio/adc/meson_saradc.c:728:

Adding a line-break right before the error message will solve this problem

Best regards,
Martin