From: kernel test robot <lkp@intel.com>
To: Xiang wangx <wangxiang@cdjrlc.com>, gerg@linux-m68k.org
Cc: kbuild-all@lists.01.org, geert@linux-m68k.org,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
Xiang wangx <wangxiang@cdjrlc.com>
Subject: Re: [PATCH] m68k: coldfire:Add const to clk_ops
Date: Tue, 31 May 2022 21:13:52 +0800 [thread overview]
Message-ID: <202205312132.iaViCBtV-lkp@intel.com> (raw)
In-Reply-To: <20220530025312.55057-1-wangxiang@cdjrlc.com>
Hi Xiang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on gerg-m68knommu/for-next]
[also build test ERROR on geert-m68k/for-next v5.18 next-20220531]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Xiang-wangx/m68k-coldfire-Add-const-to-clk_ops/20220530-105531
base: https://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git for-next
config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20220531/202205312132.iaViCBtV-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/e44f3b73f214f99802c9a010145922eb0a126933
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Xiang-wangx/m68k-coldfire-Add-const-to-clk_ops/20220530-105531
git checkout e44f3b73f214f99802c9a010145922eb0a126933
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash arch/m68k/coldfire/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> arch/m68k/coldfire/clk.c:53:8: error: expected '{' before 'const'
53 | struct const clk_ops clk_ops0 = {
| ^~~~~
arch/m68k/coldfire/clk.c:48:13: warning: '__clk_disable0' defined but not used [-Wunused-function]
48 | static void __clk_disable0(struct clk *clk)
| ^~~~~~~~~~~~~~
arch/m68k/coldfire/clk.c:43:13: warning: '__clk_enable0' defined but not used [-Wunused-function]
43 | static void __clk_enable0(struct clk *clk)
| ^~~~~~~~~~~~~
vim +53 arch/m68k/coldfire/clk.c
52
> 53 struct const clk_ops clk_ops0 = {
54 .enable = __clk_enable0,
55 .disable = __clk_disable0,
56 };
57
--
0-DAY CI Kernel Test Service
https://01.org/lkp
prev parent reply other threads:[~2022-05-31 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 2:53 [PATCH] m68k: coldfire:Add const to clk_ops Xiang wangx
2022-05-30 7:11 ` Geert Uytterhoeven
2022-05-31 13:13 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205312132.iaViCBtV-lkp@intel.com \
--to=lkp@intel.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=wangxiang@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox