From: Miaoqian Lin <linmq006@gmail.com>
To: Lee Jones <lee.jones@linaro.org>,
Mallikarjun Kasoju <mkasoju@nvidia.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-kernel@vger.kernel.org
Cc: linmq006@gmail.com
Subject: [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps
Date: Wed, 1 Jun 2022 08:32:22 +0400 [thread overview]
Message-ID: <20220601043222.64441-1-linmq006@gmail.com> (raw)
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/mfd/max77620.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c
index fec2096474ad..a6661e07035b 100644
--- a/drivers/mfd/max77620.c
+++ b/drivers/mfd/max77620.c
@@ -419,9 +419,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip)
ret = max77620_config_fps(chip, fps_child);
if (ret < 0) {
of_node_put(fps_child);
+ of_node_put(fps_np);
return ret;
}
}
+ of_node_put(fps_np);
config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0;
ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2,
--
2.25.1
next reply other threads:[~2022-06-01 4:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 4:32 Miaoqian Lin [this message]
2022-06-01 10:52 ` [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps Krzysztof Kozlowski
2022-06-15 21:44 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220601043222.64441-1-linmq006@gmail.com \
--to=linmq006@gmail.com \
--cc=krzk@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkasoju@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox