From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A9FCCA468 for ; Wed, 1 Jun 2022 14:12:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355201AbiFAOMB (ORCPT ); Wed, 1 Jun 2022 10:12:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354450AbiFAOGn (ORCPT ); Wed, 1 Jun 2022 10:06:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65866B82C8; Wed, 1 Jun 2022 07:00:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 47EC6B8175B; Wed, 1 Jun 2022 14:00:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12C88C3411D; Wed, 1 Jun 2022 14:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654092008; bh=zlr3C4xgJD135dQdTWBXK1U0qwJZQAP7U25NcO+I5cQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lV3GW+PZvSSD2WpKGQDD6OXnzDrapPpyeOjrn8YW0LBXKpvwc9q4RbJ5JWutwzEza rjejyWL9mRbwlk+Jv2SyS1jBBVQshXXnOu654QWwUg5j7o7blAeE/F2/qS6DQ6jXBo sdXnSIRmD7j1B32HRu9EYHOpjYK3CBDTQ9D0cIjJD0cKPiXKspVXuuQrjaNCR9faTi x9tpkY/PVYqYI3yMVrGI1Iqicu+7mhzn3wcJxRAzKi4INr/yJeyxFcCOa7tqtqY259 0AY7kKpRurklGnCJeCBs158f6QLWz19100d6Ago+FudBfXnr5OXGtPKye3UFTzVwFt WwQg2dc6OOTwg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peng Wu , Wei Xu , Sasha Levin , linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 09/15] ARM: hisi: Add missing of_node_put after of_find_compatible_node Date: Wed, 1 Jun 2022 09:59:44 -0400 Message-Id: <20220601135951.2005085-9-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220601135951.2005085-1-sashal@kernel.org> References: <20220601135951.2005085-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Wu [ Upstream commit 9bc72e47d4630d58a840a66a869c56b29554cfe4 ] of_find_compatible_node will increment the refcount of the returned device_node. Calling of_node_put() to avoid the refcount leak Signed-off-by: Peng Wu Signed-off-by: Wei Xu Signed-off-by: Sasha Levin --- arch/arm/mach-hisi/platsmp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-hisi/platsmp.c b/arch/arm/mach-hisi/platsmp.c index da5689ababf7..d7fbfb6d293d 100644 --- a/arch/arm/mach-hisi/platsmp.c +++ b/arch/arm/mach-hisi/platsmp.c @@ -70,14 +70,17 @@ static void __init hi3xxx_smp_prepare_cpus(unsigned int max_cpus) } ctrl_base = of_iomap(np, 0); if (!ctrl_base) { + of_node_put(np); pr_err("failed to map address\n"); return; } if (of_property_read_u32(np, "smp-offset", &offset) < 0) { + of_node_put(np); pr_err("failed to find smp-offset property\n"); return; } ctrl_base += offset; + of_node_put(np); } } @@ -163,6 +166,7 @@ static int hip01_boot_secondary(unsigned int cpu, struct task_struct *idle) if (WARN_ON(!node)) return -1; ctrl_base = of_iomap(node, 0); + of_node_put(node); /* set the secondary core boot from DDR */ remap_reg_value = readl_relaxed(ctrl_base + REG_SC_CTRL); -- 2.35.1