Re: [PATCH v2 1/7] dt-bindings: iommu: mediatek: Add phandles for mediatek infra/pericfg

Yong Wu
2022-05-26T08:21:54Z

On Wed, 2022-05-18 at 12:04 +0200, AngeloGioacchino Del Regno wrote:
> Add properties "mediatek,infracfg" and "mediatek,pericfg" to let the
> mtk_iommu driver retrieve phandles to the infracfg and pericfg
> syscon(s)
> instead of performing a per-soc compatible lookup.
>
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/iommu/mediatek,iommu.yaml | 8
> ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> index 2ae3bbad7f1a..c4af41947593 100644
> --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> @@ -101,6 +101,10 @@ properties:
> items:
> - const: bclk
>
> + mediatek,infracfg:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: The phandle to the mediatek infracfg syscon
> +

Just curious, why not put this "mediatek,infracfg" and its required
segment[6/7] into one patch?

> mediatek,larbs:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> minItems: 1
> @@ -112,6 +116,10 @@ properties:
> Refer to bindings/memory-controllers/mediatek,smi-larb.yaml.
> It must sort
> according to the local arbiter index, like larb0, larb1,
> larb2...
>
> + mediatek,pericfg:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: The phandle to the mediatek pericfg syscon
> +
> '#iommu-cells':
> const: 1
> description: |