Re: [PATCH v5 19/20] ASoC: mediatek: mt8186: add machine driver with mt6366, rt1019 and rt5682s

Mark Brown
2022-06-06T16:08:48Z

[-- Attachment #1: Type: text/plain, Size: 3555 bytes --]

On Mon, May 23, 2022 at 09:28:57PM +0800, Jiaxin Yu wrote:
> Add support for mt8186 board with mt6366, rt1019 and rt5682s.
>
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c: In function ‘mt8186_da7219_init’:
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c:58:15: error: too many arguments to function ‘snd_soc_card_jack_new’
58 | ret = snd_soc_card_jack_new(rtd->card, "Headset Jack",
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c:15:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id, int type,
| ^~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c: In function ‘mt8186_mt6366_da7219_max98357_hdmi_init’:
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c:161:15: error: too many arguments to function ‘snd_soc_card_jack_new’
161 | ret = snd_soc_card_jack_new(rtd->card, "HDMI Jack", SND_JACK_LINEOUT,
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c:15:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id, int type,
| ^~~~~~~~~~~~~~~~~~~~~
make[5]: *** [/build/stage/linux/scripts/Makefile.build:249: sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.o] Error 1
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c: In function ‘mt8186_rt5682s_init’:
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c:61:15: error: too many arguments to function ‘snd_soc_card_jack_new’
61 | ret = snd_soc_card_jack_new(rtd->card, "Headset Jack",
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c:17:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id, int type,
| ^~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c: In function ‘mt8186_mt6366_rt1019_rt5682s_hdmi_init’:
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c:137:15: error: too many arguments to function ‘snd_soc_card_jack_new’
137 | ret = snd_soc_card_jack_new(rtd->card, "HDMI Jack", SND_JACK_LINEOUT,
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c:17:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id, int type,
| ^~~~~~~~~~~~~~~~~~~~~
make[5]: *** [/build/stage/linux/scripts/Makefile.build:249: sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.o] Error 1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]