public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [axboe-block:for-5.20/io_uring 61/69] io_uring/io_uring.c:3795:6: warning: no previous prototype for 'io_assign_file'
Date: Thu, 2 Jun 2022 20:02:15 +0800	[thread overview]
Message-ID: <202206021948.3N7DAXYa-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-5.20/io_uring
head:   35527d1da9a7caedd07ab1b0a2176ea80bbdf692
commit: 7d8795a4e662b005b70330c8038f486f4465e4de [61/69] io_uring: move poll handling into its own file
config: um-x86_64_defconfig (https://download.01.org/0day-ci/archive/20220602/202206021948.3N7DAXYa-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?id=7d8795a4e662b005b70330c8038f486f4465e4de
        git remote add axboe-block https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
        git fetch --no-tags axboe-block for-5.20/io_uring
        git checkout 7d8795a4e662b005b70330c8038f486f4465e4de
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=um SUBARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   io_uring/io_uring.c: In function '__io_submit_flush_completions':
   io_uring/io_uring.c:1743:40: warning: variable 'prev' set but not used [-Wunused-but-set-variable]
    1743 |         struct io_wq_work_node *node, *prev;
         |                                        ^~~~
   io_uring/io_uring.c: At top level:
>> io_uring/io_uring.c:3795:6: warning: no previous prototype for 'io_assign_file' [-Wmissing-prototypes]
    3795 | bool io_assign_file(struct io_kiocb *req, unsigned int issue_flags)
         |      ^~~~~~~~~~~~~~


vim +/io_assign_file +3795 io_uring/io_uring.c

  3794	
> 3795	bool io_assign_file(struct io_kiocb *req, unsigned int issue_flags)
  3796	{
  3797		if (req->file || !io_op_defs[req->opcode].needs_file)
  3798			return true;
  3799	
  3800		if (req->flags & REQ_F_FIXED_FILE)
  3801			req->file = io_file_get_fixed(req, req->cqe.fd, issue_flags);
  3802		else
  3803			req->file = io_file_get_normal(req, req->cqe.fd);
  3804	
  3805		return !!req->file;
  3806	}
  3807	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-06-02 12:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206021948.3N7DAXYa-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=axboe@kernel.dk \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox