From: Michael Trimarchi <michael@amarulasolutions.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK),
linux-kernel@vger.kernel.org (open list)
Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-amarula@amarulasolutions.com,
linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK),
linux-kernel@vger.kernel.org (open list)
Subject: [RFC PATCH 1/3] clk: bd718x7: Clean up the code, no functional changes
Date: Sun, 5 Jun 2022 18:57:01 +0200 [thread overview]
Message-ID: <20220605165703.1565234-2-michael@amarulasolutions.com> (raw)
In-Reply-To: <20220605165703.1565234-1-michael@amarulasolutions.com>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
drivers/clk/clk-bd718x7.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/clk/clk-bd718x7.c b/drivers/clk/clk-bd718x7.c
index ac40b669d60b..04cc0beb67df 100644
--- a/drivers/clk/clk-bd718x7.c
+++ b/drivers/clk/clk-bd718x7.c
@@ -81,27 +81,28 @@ static int bd71837_clk_probe(struct platform_device *pdev)
struct bd718xx_clk *c;
int rval = -ENOMEM;
const char *parent_clk;
+ struct device *dev = &pdev->dev;
struct device *parent = pdev->dev.parent;
struct clk_init_data init = {
.name = "bd718xx-32k-out",
.ops = &bd71837_clk_ops,
+ .num_parents = 1,
};
enum rohm_chip_type chip = platform_get_device_id(pdev)->driver_data;
- c = devm_kzalloc(&pdev->dev, sizeof(*c), GFP_KERNEL);
+ c = devm_kzalloc(dev, sizeof(*c), GFP_KERNEL);
if (!c)
return -ENOMEM;
- c->regmap = dev_get_regmap(pdev->dev.parent, NULL);
+ c->regmap = dev_get_regmap(parent, NULL);
if (!c->regmap)
return -ENODEV;
- init.num_parents = 1;
parent_clk = of_clk_get_parent_name(parent->of_node, 0);
init.parent_names = &parent_clk;
if (!parent_clk) {
- dev_err(&pdev->dev, "No parent clk found\n");
+ dev_err(dev, "No parent clk found\n");
return -EINVAL;
}
switch (chip) {
@@ -119,7 +120,7 @@ static int bd71837_clk_probe(struct platform_device *pdev)
c->mask = CLK_OUT_EN_MASK;
break;
default:
- dev_err(&pdev->dev, "Unknown clk chip\n");
+ dev_err(dev, "Unknown clk chip\n");
return -EINVAL;
}
c->pdev = pdev;
@@ -128,15 +129,15 @@ static int bd71837_clk_probe(struct platform_device *pdev)
of_property_read_string_index(parent->of_node,
"clock-output-names", 0, &init.name);
- rval = devm_clk_hw_register(&pdev->dev, &c->hw);
+ rval = devm_clk_hw_register(dev, &c->hw);
if (rval) {
- dev_err(&pdev->dev, "failed to register 32K clk");
+ dev_err(dev, "failed to register 32K clk");
return rval;
}
- rval = devm_of_clk_add_hw_provider(&pdev->dev, of_clk_hw_simple_get,
+ rval = devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get,
&c->hw);
if (rval)
- dev_err(&pdev->dev, "adding clk provider failed\n");
+ dev_err(dev, "adding clk provider failed\n");
return rval;
}
--
2.25.1
next parent reply other threads:[~2022-06-05 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220605165703.1565234-1-michael@amarulasolutions.com>
2022-06-05 16:57 ` Michael Trimarchi [this message]
2022-06-06 5:49 ` [RFC PATCH 1/3] clk: bd718x7: Clean up the code, no functional changes Matti Vaittinen
2022-06-05 16:57 ` [RFC PATCH 2/3] clk: bd718x7: Enable the possibility to mark the clock as critical Michael Trimarchi
2022-06-06 5:25 ` Matti Vaittinen
2022-06-06 6:08 ` Michael Nazzareno Trimarchi
2024-08-14 16:00 ` Michael Nazzareno Trimarchi
2024-08-15 6:07 ` Matti Vaittinen
2022-06-05 16:57 ` [RFC PATCH 3/3] arm64: dts: imx8mn-bsh-smm-s2/pro: Add pmic clock connection Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220605165703.1565234-2-michael@amarulasolutions.com \
--to=michael@amarulasolutions.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox