public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: bleung@chromium.org, groeck@chromium.org
Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 04/13] platform/chrome: cros_ec_proto: assign buffer size from protocol info
Date: Mon,  6 Jun 2022 14:10:42 +0000	[thread overview]
Message-ID: <20220606141051.285823-5-tzungbi@kernel.org> (raw)
In-Reply-To: <20220606141051.285823-1-tzungbi@kernel.org>

`din_size` is calculated from `ec_dev->max_response`.
`ec_dev->max_response` is further calculated from the protocol info.

To make it clear, assign `din_size` and `dout_size` from protocol info
directly.

Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
 drivers/platform/chrome/cros_ec_proto.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
index 65191af5139c..629dce3e6ab3 100644
--- a/drivers/platform/chrome/cros_ec_proto.c
+++ b/drivers/platform/chrome/cros_ec_proto.c
@@ -449,12 +449,8 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev)
 			"using proto v%u\n",
 			ec_dev->proto_version);
 
-		ec_dev->din_size = ec_dev->max_response +
-			sizeof(struct ec_host_response) +
-			EC_MAX_RESPONSE_OVERHEAD;
-		ec_dev->dout_size = ec_dev->max_request +
-			sizeof(struct ec_host_request) +
-			EC_MAX_REQUEST_OVERHEAD;
+		ec_dev->din_size = proto_info->max_response_packet_size + EC_MAX_RESPONSE_OVERHEAD;
+		ec_dev->dout_size = proto_info->max_request_packet_size + EC_MAX_REQUEST_OVERHEAD;
 
 		/*
 		 * Check for PD
-- 
2.36.1.255.ge46751e96f-goog


  parent reply	other threads:[~2022-06-06 14:12 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 14:10 [PATCH 00/13] platform/chrome: Kunit tests and refactor for cros_ec_query_all() Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 01/13] platform/chrome: cros_ec_commands: fix compile errors Tzung-Bi Shih
2022-06-06 15:08   ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 02/13] platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_query_all() Tzung-Bi Shih
2022-06-06 15:18   ` Guenter Roeck
2022-06-07  0:54     ` Tzung-Bi Shih
2022-06-07 14:41       ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 03/13] platform/chrome: use macros for passthru indexes Tzung-Bi Shih
2022-06-06 15:22   ` Guenter Roeck
2022-06-06 15:23     ` Guenter Roeck
2022-06-06 14:10 ` Tzung-Bi Shih [this message]
2022-06-06 15:24   ` [PATCH 04/13] platform/chrome: cros_ec_proto: assign buffer size from protocol info Guenter Roeck
2022-06-06 14:10 ` [PATCH 05/13] platform/chrome: cros_ec_proto: remove redundant NULL check Tzung-Bi Shih
2022-06-06 15:46   ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 06/13] platform/chrome: cros_ec_proto: use cros_ec_map_error() Tzung-Bi Shih
2022-06-06 15:55   ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 07/13] platform/chrome: cros_ec_proto: separate fill_protocol_info() Tzung-Bi Shih
2022-06-06 16:06   ` Guenter Roeck
2022-06-07  0:54     ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 08/13] platform/chrome: cros_ec_proto: separate fill_protocol_info_legacy() Tzung-Bi Shih
2022-06-06 16:06   ` Guenter Roeck
2022-06-07  0:55     ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 09/13] platform/chrome: cros_ec_proto: use devm_krealloc() Tzung-Bi Shih
2022-06-06 16:04   ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 10/13] platform/chrome: cros_ec_proto: arrange get_host_command_version_mask() Tzung-Bi Shih
2022-06-06 16:09   ` Guenter Roeck
2022-06-07  0:55     ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 11/13] platform/chrome: cros_ec_proto: fix get_host_command_version_mask() returns Tzung-Bi Shih
2022-06-06 16:16   ` Guenter Roeck
2022-06-06 14:10 ` [PATCH 12/13] platform/chrome: cros_ec_proto: arrange get_host_event_wake_mask() Tzung-Bi Shih
2022-06-06 16:18   ` Guenter Roeck
2022-06-07  0:55     ` Tzung-Bi Shih
2022-06-06 14:10 ` [PATCH 13/13] platform/chrome: cros_ec_proto: fix get_host_event_wake_mask() returns Tzung-Bi Shih
2022-06-06 16:14   ` Guenter Roeck
2022-06-07  0:55     ` Tzung-Bi Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220606141051.285823-5-tzungbi@kernel.org \
    --to=tzungbi@kernel.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox