public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, patches@opensource.cirrus.com,
	alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
	Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 1/3] ASoC: wm8940: Remove warning when no plat data
Date: Mon, 6 Jun 2022 18:17:31 +0200	[thread overview]
Message-ID: <20220606181731.04b6f771@ktm> (raw)
In-Reply-To: <Yp4iGvGFD9jo4WUP@sirena.org.uk>

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

Hi Mark,

> On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote:
> > The lack of platform data in the contemporary Linux
> > shall not be the reason to display warnings to the
> > kernel logs.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>  
> 
> Given that the device requires configuration and doesn't appear to
> have any other firmware interface support that's rather a strong
> statement...

Thanks for the comment :-)

My point is that - similar codec - wm8974 don't display such warnings.
(this code was not updated/refactored for a quite long time).

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-06-06 16:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 15:44 [PATCH 1/3] ASoC: wm8940: Remove warning when no plat data Lukasz Majewski
2022-06-06 15:44 ` [PATCH 2/3] ASoC: wm8940: Rewrite code to set proper clocks Lukasz Majewski
2022-06-06 16:18   ` Mark Brown
2022-06-07 12:13     ` Lukasz Majewski
2022-06-07 12:20       ` Mark Brown
2022-06-06 15:44 ` [PATCH 3/3] ASoC: wm8940: Mute also the speaker output Lukasz Majewski
2022-06-06 16:25   ` Mark Brown
2022-06-10  9:23     ` Lukasz Majewski
2022-06-10 11:48       ` Mark Brown
2022-06-06 15:49 ` [PATCH 1/3] ASoC: wm8940: Remove warning when no plat data Mark Brown
2022-06-06 16:17   ` Lukasz Majewski [this message]
2022-06-06 16:52     ` Mark Brown
2022-06-07 12:30       ` Lukasz Majewski
2022-06-07 12:35         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220606181731.04b6f771@ktm \
    --to=lukma@denx.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox