From: Miaoqian Lin <linmq006@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Miaoqian Lin <linmq006@gmail.com>,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] sparc: Fix reference leak in scan_of_devices
Date: Tue, 7 Jun 2022 07:32:58 +0400 [thread overview]
Message-ID: <20220607033306.688-1-linmq006@gmail.com> (raw)
of_find_node_by_path() returns a node pointer with
refcount incremented, we should use of_node_put() on it when not need
anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: cf44bbc26cf1 ("[SPARC]: Beginnings of generic of_device framework.")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/sparc/kernel/of_device_32.c | 4 +++-
arch/sparc/kernel/of_device_64.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/sparc/kernel/of_device_32.c b/arch/sparc/kernel/of_device_32.c
index 4ebf51e6e78e..020b1c023d75 100644
--- a/arch/sparc/kernel/of_device_32.c
+++ b/arch/sparc/kernel/of_device_32.c
@@ -412,8 +412,10 @@ static int __init scan_of_devices(void)
struct platform_device *parent;
parent = scan_one_device(root, NULL);
- if (!parent)
+ if (!parent) {
+ of_node_put(root);
return 0;
+ }
scan_tree(root->child, &parent->dev);
return 0;
diff --git a/arch/sparc/kernel/of_device_64.c b/arch/sparc/kernel/of_device_64.c
index 5a9f86b1d4e7..f044b4c1975b 100644
--- a/arch/sparc/kernel/of_device_64.c
+++ b/arch/sparc/kernel/of_device_64.c
@@ -705,8 +705,10 @@ static int __init scan_of_devices(void)
struct platform_device *parent;
parent = scan_one_device(root, NULL);
- if (!parent)
+ if (!parent) {
+ of_node_put(root);
return 0;
+ }
scan_tree(root->child, &parent->dev);
return 0;
--
2.25.1
next reply other threads:[~2022-06-07 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 3:32 Miaoqian Lin [this message]
2022-06-07 3:32 ` [PATCH 3/3] sparc: prom: Fix reference leak in of_console_init Miaoqian Lin
2022-06-07 3:33 ` [PATCH 1/3] sparc: kernel: Fix reference leak in jbusmc_probe Miaoqian Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607033306.688-1-linmq006@gmail.com \
--to=linmq006@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox