* [PATCH v1 1/1] nvdimm/namespace: return uuid_null only once in nd_dev_to_uuid()
@ 2022-06-07 15:25 Andy Shevchenko
2022-07-14 18:24 ` Dan Williams
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2022-06-07 15:25 UTC (permalink / raw)
To: Dan Williams, nvdimm, linux-kernel
Cc: Vishal Verma, Dave Jiang, Ira Weiny, Andy Shevchenko
Refactor nd_dev_to_uuid() in order to make code shorter and cleaner
by joining conditions and hence returning uuid_null only once.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/nvdimm/namespace_devs.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
index bf4f5c09d9b1..3dae17c90e8c 100644
--- a/drivers/nvdimm/namespace_devs.c
+++ b/drivers/nvdimm/namespace_devs.c
@@ -170,15 +170,12 @@ EXPORT_SYMBOL(nvdimm_namespace_disk_name);
const uuid_t *nd_dev_to_uuid(struct device *dev)
{
- if (!dev)
- return &uuid_null;
-
- if (is_namespace_pmem(dev)) {
+ if (dev && is_namespace_pmem(dev)) {
struct nd_namespace_pmem *nspm = to_nd_namespace_pmem(dev);
return nspm->uuid;
- } else
- return &uuid_null;
+ }
+ return &uuid_null;
}
EXPORT_SYMBOL(nd_dev_to_uuid);
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH v1 1/1] nvdimm/namespace: return uuid_null only once in nd_dev_to_uuid()
2022-06-07 15:25 [PATCH v1 1/1] nvdimm/namespace: return uuid_null only once in nd_dev_to_uuid() Andy Shevchenko
@ 2022-07-14 18:24 ` Dan Williams
2022-07-14 18:45 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Dan Williams @ 2022-07-14 18:24 UTC (permalink / raw)
To: Andy Shevchenko, Dan Williams, nvdimm, linux-kernel
Cc: Vishal Verma, Dave Jiang, Ira Weiny, Andy Shevchenko
Andy Shevchenko wrote:
> Refactor nd_dev_to_uuid() in order to make code shorter and cleaner
> by joining conditions and hence returning uuid_null only once.
Apologies for the delay, applied for v5.20.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] nvdimm/namespace: return uuid_null only once in nd_dev_to_uuid()
2022-07-14 18:24 ` Dan Williams
@ 2022-07-14 18:45 ` Andy Shevchenko
2022-07-14 20:50 ` Dan Williams
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2022-07-14 18:45 UTC (permalink / raw)
To: Dan Williams; +Cc: nvdimm, linux-kernel, Vishal Verma, Dave Jiang, Ira Weiny
On Thu, Jul 14, 2022 at 11:24:05AM -0700, Dan Williams wrote:
> Andy Shevchenko wrote:
> > Refactor nd_dev_to_uuid() in order to make code shorter and cleaner
> > by joining conditions and hence returning uuid_null only once.
>
> Apologies for the delay, applied for v5.20.
No problem and thanks!
P.S. One patch out of three is a fix, would be nice to have it in v5.19
release.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] nvdimm/namespace: return uuid_null only once in nd_dev_to_uuid()
2022-07-14 18:45 ` Andy Shevchenko
@ 2022-07-14 20:50 ` Dan Williams
0 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2022-07-14 20:50 UTC (permalink / raw)
To: Andy Shevchenko, Dan Williams
Cc: nvdimm, linux-kernel, Vishal Verma, Dave Jiang, Ira Weiny
Andy Shevchenko wrote:
> On Thu, Jul 14, 2022 at 11:24:05AM -0700, Dan Williams wrote:
> > Andy Shevchenko wrote:
> > > Refactor nd_dev_to_uuid() in order to make code shorter and cleaner
> > > by joining conditions and hence returning uuid_null only once.
> >
> > Apologies for the delay, applied for v5.20.
>
> No problem and thanks!
>
> P.S. One patch out of three is a fix, would be nice to have it in v5.19
> release.
Found it, applied it.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-14 20:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-07 15:25 [PATCH v1 1/1] nvdimm/namespace: return uuid_null only once in nd_dev_to_uuid() Andy Shevchenko
2022-07-14 18:24 ` Dan Williams
2022-07-14 18:45 ` Andy Shevchenko
2022-07-14 20:50 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox