Re: [PATCH 5.17 000/772] 5.17.14-rc1 review

Pavel Machek
2022-06-18T11:37:34Z

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]

Hi!

> >> Fixes: bc082a55d25c ("bcache: fix inaccurate io state for detached
> > ...
> >
> >> +++ b/drivers/md/bcache/request.c
> >> @@ -1107,6 +1107,12 @@ static void detached_dev_do_request(struct
> >> bcache_device *d, struct bio *bio,
> >> * which would call closure_get(&dc->disk.cl)
> >> */
> >> ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO);
> >> + if (!ddip) {
> >> + bio->bi_status = BLK_STS_RESOURCE;
> >> + bio->bi_end_io(bio);
> >> + return;
> >> + }
> >> +
> >> ddip->d = d;
> >> /* Count on the bcache device */
> >> ddip->orig_bdev = orig_bdev;
> >>
> >
> > So... for patch to make any difference, memory allocation has to fail
> > and ddip has to be NULL.
> >
> > Before the patch, it would oops in "ddip->d = d;". With the patch, you
> > do some kind of error handling. Even if it is buggy, it should not do
> > more harm than immediate oops.
>
> I just receive this single email and don’t have any idea for the context and what the problem is. Where can I see the whole conversation?
>

Discussion happened on stable@vger.kernel.org mailing lists, archives
should be easily available. Copy went to lkml, too.

Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]