From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA87CCA48E for ; Tue, 7 Jun 2022 20:17:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376416AbiFGUQq (ORCPT ); Tue, 7 Jun 2022 16:16:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355980AbiFGT0P (ORCPT ); Tue, 7 Jun 2022 15:26:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F5D219FB3E; Tue, 7 Jun 2022 11:09:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 61E5861680; Tue, 7 Jun 2022 18:09:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 741EFC385A2; Tue, 7 Jun 2022 18:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654625377; bh=6ZnJghzKDlKCod7kwo/tZC8Br7JRg0a33v+qO538iH4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z76297fprOSGX40ncnKsjvrdjpaC3DIh9N2zeIZxQ/WNS4xukhWm1getBLShuIjIL TAXpsjawG/Iu4PP2Kg6X+KozhRvBFz8/5zCg7rFUsN2rkBYBZ430juv2m791tx+alq NvGB9aCSVn40ku4T7Z+icRnUC006FU1a11enUQ/g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xiao Ni , Song Liu Subject: [PATCH 5.15 666/667] md: fix double free of io_acct_set bioset Date: Tue, 7 Jun 2022 19:05:31 +0200 Message-Id: <20220607164954.615559053@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164934.766888869@linuxfoundation.org> References: <20220607164934.766888869@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiao Ni commit 42b805af102471f53e3c7867b8c2b502ea4eef7e upstream. Now io_acct_set is alloc and free in personality. Remove the codes that free io_acct_set in md_free and md_stop. Fixes: 0c031fd37f69 (md: Move alloc/free acct bioset in to personality) Signed-off-by: Xiao Ni Signed-off-by: Song Liu Signed-off-by: Greg Kroah-Hartman --- drivers/md/md.c | 4 ---- 1 file changed, 4 deletions(-) --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -5588,8 +5588,6 @@ static void md_free(struct kobject *ko) bioset_exit(&mddev->bio_set); bioset_exit(&mddev->sync_set); - if (mddev->level != 1 && mddev->level != 10) - bioset_exit(&mddev->io_acct_set); kfree(mddev); } @@ -6277,8 +6275,6 @@ void md_stop(struct mddev *mddev) __md_stop(mddev); bioset_exit(&mddev->bio_set); bioset_exit(&mddev->sync_set); - if (mddev->level != 1 && mddev->level != 10) - bioset_exit(&mddev->io_acct_set); } EXPORT_SYMBOL_GPL(md_stop);