From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD3BCCA489 for ; Tue, 7 Jun 2022 18:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353682AbiFGSp5 (ORCPT ); Tue, 7 Jun 2022 14:45:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351917AbiFGSQs (ORCPT ); Tue, 7 Jun 2022 14:16:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62D4D13391A; Tue, 7 Jun 2022 10:50:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DD38861794; Tue, 7 Jun 2022 17:50:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67A1EC341C4; Tue, 7 Jun 2022 17:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654624207; bh=/iUON9WW6bsYbfVqaGxLRyqJA2zgabLnd46UiDlgoD8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uASTYLNCryH3nlHEQvqaMECw6fdUuBL04k81iws1utq1dmHM1VU/QnWQBEXBfjrrU KdzVKzNU3S42avTzouAHJqSe8AHuhGCua0XFYo/4dapxPdLcTrAdF1gafHiuz2s4Ld arJKDPzSeImddabzXUqN6d7j0/Lvwak2NAyhgKY6GWOrtscYBm2gcv0lP6o9BgImm1 PPDsjpHwbVTEcMro71q1GLrTNSMtzwhjQnQncpaTLOfVoFGMAOT4lk35m7X1l4r6bL ZsO80u3PsVTJNArraN8wVL47hVN28ByL+HhHrZgy7E//xNtB7kkn6hrIGf765zM8bI 9uB/pGimt9aVA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhen Ni , Greg Kroah-Hartman , Sasha Levin , ok@artecdesign.ee, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.18 13/68] USB: host: isp116x: check return value after calling platform_get_resource() Date: Tue, 7 Jun 2022 13:47:39 -0400 Message-Id: <20220607174846.477972-13-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607174846.477972-1-sashal@kernel.org> References: <20220607174846.477972-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhen Ni [ Upstream commit 134a3408c2d3f7e23eb0e4556e0a2d9f36c2614e ] It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Zhen Ni Link: https://lore.kernel.org/r/20220302033716.31272-1-nizhen@uniontech.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/isp116x-hcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 8835f6bd528e..8c7f0991c21b 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c @@ -1541,10 +1541,12 @@ static int isp116x_remove(struct platform_device *pdev) iounmap(isp116x->data_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - release_mem_region(res->start, 2); + if (res) + release_mem_region(res->start, 2); iounmap(isp116x->addr_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, 2); + if (res) + release_mem_region(res->start, 2); usb_put_hcd(hcd); return 0; -- 2.35.1