From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40120CCA48D for ; Tue, 7 Jun 2022 19:53:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357986AbiFGTvW (ORCPT ); Tue, 7 Jun 2022 15:51:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354354AbiFGSq4 (ORCPT ); Tue, 7 Jun 2022 14:46:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3669A12AC4; Tue, 7 Jun 2022 11:00:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C2D64B82182; Tue, 7 Jun 2022 18:00:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECDCBC385A5; Tue, 7 Jun 2022 18:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654624850; bh=1VUA0cPwHrZpHe5xpepOfsqAMeMYOWh+2QgQ3qGUM4s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r+f/0hWrZBPrdvOeSbphkI2h24nQjGVLrLlhzZ4Qx0Z28qQdKrnupLJ+N2j3Dn/t3 OhTbEkEKmhvki2l4NGmTt4ZNqFpmrBL96mO5ZKLOZQ7Shww7vp+3dfrZTTi3ZZsuzl vAJ67VvcyA1i62sHVETmLY9jAskmU4k5bLCZAGDDgylNRhb4F6tOYtMhxZ4l3Lp8/T D/JriKS85qdNGMCfVgtrt3eM30aOkzOLy0Dic3qYkQzhRp+Rldm/UWJQdQgc/pTjQ0 gHw1LrZqJIXh/gXTLK6pAzE02wfJVwhw5t+6+WonlP0VOjtV3+uqrbClnFN2pKLzfs 5xhxuhMFbiIug== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Shuah Khan , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 5.4 13/34] misc: rtsx: set NULL intfdata when probe fails Date: Tue, 7 Jun 2022 13:59:48 -0400 Message-Id: <20220607180011.481266-13-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607180011.481266-1-sashal@kernel.org> References: <20220607180011.481266-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shuah Khan [ Upstream commit f861d36e021e1ac4a0a2a1f6411d623809975d63 ] rtsx_usb_probe() doesn't call usb_set_intfdata() to null out the interface pointer when probe fails. This leaves a stale pointer. Noticed the missing usb_set_intfdata() while debugging an unrelated invalid DMA mapping problem. Fix it with a call to usb_set_intfdata(..., NULL). Signed-off-by: Shuah Khan Link: https://lore.kernel.org/r/20220429210913.46804-1-skhan@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/misc/cardreader/rtsx_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/cardreader/rtsx_usb.c b/drivers/misc/cardreader/rtsx_usb.c index a328cab11014..4aef33d07cc3 100644 --- a/drivers/misc/cardreader/rtsx_usb.c +++ b/drivers/misc/cardreader/rtsx_usb.c @@ -667,6 +667,7 @@ static int rtsx_usb_probe(struct usb_interface *intf, return 0; out_init_fail: + usb_set_intfdata(ucr->pusb_intf, NULL); usb_free_coherent(ucr->pusb_dev, IOBUF_SIZE, ucr->iobuf, ucr->iobuf_dma); return ret; -- 2.35.1