public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Zhen Ni <nizhen@uniontech.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	ok@artecdesign.ee, linux-usb@vger.kernel.org
Subject: [PATCH AUTOSEL 5.4 08/34] USB: host: isp116x: check return value after calling platform_get_resource()
Date: Tue,  7 Jun 2022 13:59:43 -0400	[thread overview]
Message-ID: <20220607180011.481266-8-sashal@kernel.org> (raw)
In-Reply-To: <20220607180011.481266-1-sashal@kernel.org>

From: Zhen Ni <nizhen@uniontech.com>

[ Upstream commit 134a3408c2d3f7e23eb0e4556e0a2d9f36c2614e ]

It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Signed-off-by: Zhen Ni <nizhen@uniontech.com>
Link: https://lore.kernel.org/r/20220302033716.31272-1-nizhen@uniontech.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/usb/host/isp116x-hcd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
index a87c0b26279e..00a4e12a1f15 100644
--- a/drivers/usb/host/isp116x-hcd.c
+++ b/drivers/usb/host/isp116x-hcd.c
@@ -1541,10 +1541,12 @@ static int isp116x_remove(struct platform_device *pdev)
 
 	iounmap(isp116x->data_reg);
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-	release_mem_region(res->start, 2);
+	if (res)
+		release_mem_region(res->start, 2);
 	iounmap(isp116x->addr_reg);
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	release_mem_region(res->start, 2);
+	if (res)
+		release_mem_region(res->start, 2);
 
 	usb_put_hcd(hcd);
 	return 0;
-- 
2.35.1


  parent reply	other threads:[~2022-06-07 19:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 17:59 [PATCH AUTOSEL 5.4 01/34] iio: dummy: iio_simple_dummy: check the return value of kstrdup() Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 02/34] iio: st_sensors: Add a local lock for protecting odr Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 03/34] lkdtm/usercopy: Expand size of "out of frame" object Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 04/34] tty: synclink_gt: Fix null-pointer-dereference in slgt_clean() Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 05/34] tty: Fix a possible resource leak in icom_probe Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 06/34] drivers: staging: rtl8192u: Fix deadlock in ieee80211_beacons_stop() Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 07/34] drivers: staging: rtl8192e: Fix deadlock in rtllib_beacons_stop() Sasha Levin
2022-06-07 17:59 ` Sasha Levin [this message]
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 09/34] drivers: tty: serial: Fix deadlock in sa1100_set_termios() Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 10/34] drivers: usb: host: Fix deadlock in oxu_bus_suspend() Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 11/34] USB: hcd-pci: Fully suspend across freeze/thaw cycle Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 12/34] usb: dwc2: gadget: don't reset gadget's driver->bus Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 13/34] misc: rtsx: set NULL intfdata when probe fails Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 14/34] extcon: Modify extcon device to be created after driver data is set Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 15/34] clocksource/drivers/sp804: Avoid error on multiple instances Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 16/34] staging: rtl8712: fix uninit-value in usb_read8() and friends Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 17/34] staging: rtl8712: fix uninit-value in r871xu_drv_init() Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 18/34] serial: msm_serial: disable interrupts in __msm_console_write() Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 19/34] kernfs: Separate kernfs_pr_cont_buf and rename_lock Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 20/34] watchdog: wdat_wdt: Stop watchdog when rebooting the system Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 21/34] md: don't unregister sync_thread with reconfig_mutex held Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 22/34] md: protect md_unregister_thread from reentrancy Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 23/34] scsi: myrb: Fix up null pointer access on myrb_cleanup() Sasha Levin
2022-06-07 17:59 ` [PATCH AUTOSEL 5.4 24/34] Revert "net: af_key: add check for pfkey_broadcast in function pfkey_process" Sasha Levin
2022-06-07 18:00 ` [PATCH AUTOSEL 5.4 25/34] ceph: allow ceph.dir.rctime xattr to be updatable Sasha Levin
2022-06-07 18:00 ` [PATCH AUTOSEL 5.4 26/34] drm/radeon: fix a possible null pointer dereference Sasha Levin
2022-06-07 18:00 ` [PATCH AUTOSEL 5.4 27/34] modpost: fix undefined behavior of is_arm_mapping_symbol() Sasha Levin
2022-06-07 18:00 ` [PATCH AUTOSEL 5.4 28/34] x86/cpu: Elide KCSAN for cpu_has() and friends Sasha Levin
2022-06-07 18:00 ` [PATCH AUTOSEL 5.4 29/34] nbd: call genl_unregister_family() first in nbd_cleanup() Sasha Levin
2022-06-07 18:00 ` [PATCH AUTOSEL 5.4 30/34] nbd: fix race between nbd_alloc_config() and module removal Sasha Levin
2022-06-07 18:00 ` [PATCH AUTOSEL 5.4 31/34] nbd: fix io hung while disconnecting device Sasha Levin
2022-06-07 18:00 ` [PATCH AUTOSEL 5.4 32/34] s390/gmap: voluntarily schedule during key setting Sasha Levin
2022-06-07 18:00 ` [PATCH AUTOSEL 5.4 33/34] cifs: version operations for smb20 unneeded when legacy support disabled Sasha Levin
2022-06-07 18:00 ` [PATCH AUTOSEL 5.4 34/34] nodemask: Fix return values to be unsigned Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220607180011.481266-8-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nizhen@uniontech.com \
    --cc=ok@artecdesign.ee \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox