From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58EF0CCA486 for ; Tue, 7 Jun 2022 19:53:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357722AbiFGTuq (ORCPT ); Tue, 7 Jun 2022 15:50:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354513AbiFGSrG (ORCPT ); Tue, 7 Jun 2022 14:47:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 874ED81484; Tue, 7 Jun 2022 11:01:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 44357B82368; Tue, 7 Jun 2022 18:01:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2652CC3411F; Tue, 7 Jun 2022 18:01:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654624899; bh=hRGWsqzjKnMuK3JfTJG3FS+Mpovkt+WKMV9fQyy9qCc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gPrP+JBJ/1vRNZLuGrvd9YQAWUWY0Kubv6z98CqHyGXFUqRY9H7TKU6A0zwvJuYzK oxFiEbD0Udk5FyA3KwPb4hPCJxmoMeiEjGiHIGp38nTVdUJSLSTZ8gxxKhUGMUc+a3 mKPMHvkeqrIdnD7KoZVXuWkDVOk02TAXc+SzQn3L6d84bPkFG+i9RfbV52nrWAnyTV glfsnUsdSP2mVOzi/KqznincFUxZRgW9d8UKUZgLrpFDgtH1Rcy3qtUecJCvQMnQA0 SD+6qKjpc4OTaKqNaOysfO958TMFeixyJ6zBbfB0BZYN5usdoh+B6kjPXOhKzBvgOP 5cNV39U1E9wIg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Huang Guobin , Jiri Slaby , Greg Kroah-Hartman , Sasha Levin , linux-serial@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 04/27] tty: Fix a possible resource leak in icom_probe Date: Tue, 7 Jun 2022 14:01:08 -0400 Message-Id: <20220607180133.481701-4-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607180133.481701-1-sashal@kernel.org> References: <20220607180133.481701-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huang Guobin [ Upstream commit ee157a79e7c82b01ae4c25de0ac75899801f322c ] When pci_read_config_dword failed, call pci_release_regions() and pci_disable_device() to recycle the resource previously allocated. Reviewed-by: Jiri Slaby Signed-off-by: Huang Guobin Link: https://lore.kernel.org/r/20220331091005.3290753-1-huangguobin4@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/icom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c index ad374f7c476d..cb950c78d66d 100644 --- a/drivers/tty/serial/icom.c +++ b/drivers/tty/serial/icom.c @@ -1501,7 +1501,7 @@ static int icom_probe(struct pci_dev *dev, retval = pci_read_config_dword(dev, PCI_COMMAND, &command_reg); if (retval) { dev_err(&dev->dev, "PCI Config read FAILED\n"); - return retval; + goto probe_exit0; } pci_write_config_dword(dev, PCI_COMMAND, -- 2.35.1