From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92667C43334 for ; Tue, 7 Jun 2022 19:48:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356557AbiFGTsq (ORCPT ); Tue, 7 Jun 2022 15:48:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353539AbiFGSrl (ORCPT ); Tue, 7 Jun 2022 14:47:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17CC1BA54F; Tue, 7 Jun 2022 11:03:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 73FE2B82366; Tue, 7 Jun 2022 18:03:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE15FC36AFE; Tue, 7 Jun 2022 18:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654624980; bh=dhBkq9o/krAgO1SYEui+pCMcu2noGqrumSdoatVq+5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mYXOYUT8HzZJFlqZKAmlxQTIlOz/X7PioqDIMhVC8llhSozGnBUkYLK1hbcq18d1U w2orJ/VfPo+TPyHFenfm3sP7iQdHkqLsX9uHoTIK99EvcjgIyPo++TxlccbPAvU6lY vePPLqyG+Jb6RJ8aS4i1Evvg56prFSJcWWlrzv9yAlL/UVKBYD+DqjRMkak1T59bDX hATMRIN/4fPhwQP06ueW0THChX69vHffmHrQ2SKTZ/FCp6ZGxXUnLbCHT59WvYTX9j cwDJYnnd4fqcMC8lpCVXE0HUR0pyoN1c4zsoy04nXlRZGRK3glk4h8bzyh0LVUdlU9 IRVbxLQMvYYIg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: John Ogness , Marek Szyprowski , Petr Mladek , Greg Kroah-Hartman , Sasha Levin , agross@kernel.org, bjorn.andersson@linaro.org, jirislaby@kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 15/25] serial: msm_serial: disable interrupts in __msm_console_write() Date: Tue, 7 Jun 2022 14:02:16 -0400 Message-Id: <20220607180229.482040-15-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607180229.482040-1-sashal@kernel.org> References: <20220607180229.482040-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: John Ogness [ Upstream commit aabdbb1b7a5819e18c403334a31fb0cc2c06ad41 ] __msm_console_write() assumes that interrupts are disabled, but with threaded console printers it is possible that the write() callback of the console is called with interrupts enabled. Explicitly disable interrupts using local_irq_save() to preserve the assumed context. Reported-by: Marek Szyprowski Reviewed-by: Petr Mladek Signed-off-by: John Ogness Link: https://lore.kernel.org/r/20220506213324.470461-1-john.ogness@linutronix.de Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/msm_serial.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 7848e9455950..3df3716caa56 100644 --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -1587,6 +1587,7 @@ static inline struct uart_port *msm_get_port_from_line(unsigned int line) static void __msm_console_write(struct uart_port *port, const char *s, unsigned int count, bool is_uartdm) { + unsigned long flags; int i; int num_newlines = 0; bool replaced = false; @@ -1604,6 +1605,8 @@ static void __msm_console_write(struct uart_port *port, const char *s, num_newlines++; count += num_newlines; + local_irq_save(flags); + if (port->sysrq) locked = 0; else if (oops_in_progress) @@ -1649,6 +1652,8 @@ static void __msm_console_write(struct uart_port *port, const char *s, if (locked) spin_unlock(&port->lock); + + local_irq_restore(flags); } static void msm_console_write(struct console *co, const char *s, -- 2.35.1