From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E57D9C433EF for ; Tue, 7 Jun 2022 19:46:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357270AbiFGTqm (ORCPT ); Tue, 7 Jun 2022 15:46:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354617AbiFGSrb (ORCPT ); Tue, 7 Jun 2022 14:47:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07D04344C1; Tue, 7 Jun 2022 11:02:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9A29B618D3; Tue, 7 Jun 2022 18:02:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5908BC385A5; Tue, 7 Jun 2022 18:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654624954; bh=1OU0RzNa4702j9LL3ywBApit50031ThIizCQdJtB1AE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tNxT8Q9XbObUaTXkrMIKN1wwJ2HUrrELxSkUzaJTPbpktMpc3Q6yUlAP7ifXp59fX +Yma3sGt5+lS/wF+prcY1Y9yDqR9hXHERBMYSIOjHZMC+VMQFM4uFaZ6t6tfhi0IA4 GnAS0lpp8m+1nbaDr9vvakGjaasAOPc/X2tJzLFLzQT1YGRvd5Da78dXdXoWqGsC4t nzMtWqFS18OqLPjvLBCvdkLSDviAIspCpo0j0ETmlGc8D13qMi2HvEN1h5kjKc4VPO 7DnS93W894u8eSKkw2oLo6QugSdAruuuIBd01APQIBbrBGzeY0GBzqk6GtqSjpxgPI VFNTdDEjBR6lg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zheyu Ma , Jiri Slaby , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.14 03/25] tty: synclink_gt: Fix null-pointer-dereference in slgt_clean() Date: Tue, 7 Jun 2022 14:02:04 -0400 Message-Id: <20220607180229.482040-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607180229.482040-1-sashal@kernel.org> References: <20220607180229.482040-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zheyu Ma [ Upstream commit 689ca31c542687709ba21ec2195c1fbce34fd029 ] When the driver fails at alloc_hdlcdev(), and then we remove the driver module, we will get the following splat: [ 25.065966] general protection fault, probably for non-canonical address 0xdffffc0000000182: 0000 [#1] PREEMPT SMP KASAN PTI [ 25.066914] KASAN: null-ptr-deref in range [0x0000000000000c10-0x0000000000000c17] [ 25.069262] RIP: 0010:detach_hdlc_protocol+0x2a/0x3e0 [ 25.077709] Call Trace: [ 25.077924] [ 25.078108] unregister_hdlc_device+0x16/0x30 [ 25.078481] slgt_cleanup+0x157/0x9f0 [synclink_gt] Fix this by checking whether the 'info->netdev' is a null pointer first. Reviewed-by: Jiri Slaby Signed-off-by: Zheyu Ma Link: https://lore.kernel.org/r/20220410114814.3920474-1-zheyuma97@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/synclink_gt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c index 9d68f89a2bf8..4b5ff6e173bd 100644 --- a/drivers/tty/synclink_gt.c +++ b/drivers/tty/synclink_gt.c @@ -1822,6 +1822,8 @@ static int hdlcdev_init(struct slgt_info *info) */ static void hdlcdev_exit(struct slgt_info *info) { + if (!info->netdev) + return; unregister_hdlc_device(info->netdev); free_netdev(info->netdev); info->netdev = NULL; -- 2.35.1