From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB1CCCA47C for ; Tue, 7 Jun 2022 19:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357018AbiFGT6l (ORCPT ); Tue, 7 Jun 2022 15:58:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348242AbiFGSvy (ORCPT ); Tue, 7 Jun 2022 14:51:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17739149D8D; Tue, 7 Jun 2022 11:03:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E2D9617B4; Tue, 7 Jun 2022 18:03:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7D4CC3411C; Tue, 7 Jun 2022 18:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654625009; bh=lWmHQhIlKE3b0pTV4xUP99UGuC7uf0M6GoZ2g+qfm/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LPgNqxl6TeBr/N8mnA9cM36lWuQ8knHzWU0Eyfd18bj+ZfmVYZQ/LutSazMwKTcmN O5bEQfPKCkEewNoIVIsoxrH7i0cbxy5ZRvezezFtzXGjxbBiGF2hvynIEuLYQ7xQX6 ZIjQg075Dj/9K3PdHpEnOc093vHLZhfDFq4yjsK7Aop48XX1WaB1qNV/ftOvxBYweP MM8ZjEbLjE0YhfRENdY6ovHA0gInBJ2nj9NKZmCJg/rwPzMJipPVtw8tuFps5/0+XB 8BFaAxrFmienrYOOYGb7cdO8sorRVhnSnu07F4C9fD74FDi9/D0N8uXtpGpHtt5YOP S03ulAGAlI5NQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhen Ni , Greg Kroah-Hartman , Sasha Levin , ok@artecdesign.ee, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 06/19] USB: host: isp116x: check return value after calling platform_get_resource() Date: Tue, 7 Jun 2022 14:03:01 -0400 Message-Id: <20220607180317.482354-6-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220607180317.482354-1-sashal@kernel.org> References: <20220607180317.482354-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhen Ni [ Upstream commit 134a3408c2d3f7e23eb0e4556e0a2d9f36c2614e ] It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Zhen Ni Link: https://lore.kernel.org/r/20220302033716.31272-1-nizhen@uniontech.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/isp116x-hcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index d089b3fb7a13..c32145e63aea 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c @@ -1551,10 +1551,12 @@ static int isp116x_remove(struct platform_device *pdev) iounmap(isp116x->data_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - release_mem_region(res->start, 2); + if (res) + release_mem_region(res->start, 2); iounmap(isp116x->addr_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, 2); + if (res) + release_mem_region(res->start, 2); usb_put_hcd(hcd); return 0; -- 2.35.1